Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run docstring tests again #2576

Merged
merged 1 commit into from
Nov 26, 2024
Merged

ci: Run docstring tests again #2576

merged 1 commit into from
Nov 26, 2024

Conversation

rohansingh
Copy link
Contributor

This comparison expression has always been broken.

However in #2334 it changed from != 'true' to == 'false'. So the tests went from always running to never running.

This comparison expression has always been broken.

However in #2334 it changed from `!= 'true'` to `== 'false'`.
So the tests went from always running to never running.
@rohansingh
Copy link
Contributor Author

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @mwaskom will follow-up review this.

@rohansingh rohansingh merged commit 6dcd0c7 into main Nov 26, 2024
23 checks passed
@rohansingh rohansingh deleted the rohan/docstring-test branch November 26, 2024 17:22
@mwaskom
Copy link
Contributor

mwaskom commented Nov 26, 2024

Thanks, gonna blame the robot for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants