Add docstring for async_merge #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freider
reviewed
Nov 26, 2024
freider
approved these changes
Nov 26, 2024
rohansingh
force-pushed
the
rohan/doc
branch
from
64a3bc7 to
a9f2d41
Compare
rohansingh
force-pushed
the
rohan/doc
branch
from
a9f2d41 to
30da9af
Compare
rohansingh
force-pushed
the
rohan/doc
branch
from
30da9af to
e4db861
Compare
|
Interesting - the reactivated docstring testing seems to trigger an error on Python 3.9 which also triggers a bug in pytest-markdown-docs that prevents it from showing the traceback of the error 🤦 I'll take a look |
|
Fix for actual bug in Volumes that triggered the failing test: #2581 Also added an issue on pytest-markdown-docs for the borked traceback, but won't prioritize fixing that right now: modal-labs/pytest-markdown-docs#36 |
freider
reviewed
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.