New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOD-2454: remove aiostream dependency: async_map #2349

Closed

kramstrom wants to merge 48 commits into main from kramstrom/mod-2454-remove-aiostream-dependency-async_map

Contributor

kramstrom commented Oct 17, 2024 •

edited

Loading

continue splitting #2320 up into multiple PRs as it grew quite big. This adds async_map and async_map_ordered which are the last dependencies we have on the aiostream package

kramstrom and others added 16 commits

October 16, 2024 15:09


          async_merge

5d829be


          test

f67fff4


          feedback

9f99d5e


          typing

6fefd8e


          typing

295da40


          typing

4bdd660


          Merge branch 'main' into kramstrom/mod-2454-remove-aiostream-dependen…

b644bbe

…cy-async_merge


          Merge branch 'main' of github.com:modal-labs/modal-client into kramst…

c6a41f0

…rom/mod-2454-remove-aiostream-dependency-async_map


          async_map

7870fe6


          Merge branch 'main' of github.com:modal-labs/modal-client into kramst…

…rom/mod-2454-remove-aiostream-dependency-async_map


          typing

9103d5d


          remove

a745f57


          remove

a11769b

fix

b12ba5f


          wrapping

80f2a65

fix

f976685

kramstrom requested a review from freider

October 18, 2024 12:48


          Merge branch 'main' into kramstrom/mod-2454-remove-aiostream-dependen…

31b1913

…cy-async_map

freider reviewed

View reviewed changes

modal/_utils/async_utils.py Show resolved Hide resolved

freider reviewed

View reviewed changes

modal/_utils/async_utils.py Outdated Show resolved Hide resolved

freider reviewed

View reviewed changes

modal/_utils/async_utils.py Outdated Show resolved Hide resolved

freider reviewed

View reviewed changes

modal/_utils/async_utils.py Outdated Show resolved Hide resolved

freider reviewed

View reviewed changes

modal/_utils/async_utils.py Outdated Show resolved Hide resolved

freider reviewed

View reviewed changes

modal/_utils/async_utils.py Outdated Show resolved Hide resolved

freider reviewed

View reviewed changes

modal/_utils/async_utils.py Outdated Show resolved Hide resolved

freider reviewed

View reviewed changes

modal/_utils/async_utils.py Outdated Show resolved Hide resolved

freider reviewed

View reviewed changes

modal/_utils/async_utils.py Outdated Show resolved Hide resolved

freider reviewed

View reviewed changes

modal/_utils/async_utils.py Outdated Show resolved Hide resolved

freider reviewed

View reviewed changes

modal/_utils/async_utils.py Outdated Show resolved Hide resolved

freider reviewed

View reviewed changes

modal/_utils/async_utils.py Outdated Show resolved Hide resolved

kramstrom added 9 commits

October 21, 2024 11:33


          typing

20ebf90


          typing

f4e3efd


          fixes

73acd60


          type

9082db2


          Merge branch 'main' of github.com:modal-labs/modal-client into kramst…

e7845d7

…rom/mod-2454-remove-aiostream-dependency-async_map


          type

ee5b26b


          fixes

96ab30d


          more tests

5f439b0


          more tests

f5dcfd7

kramstrom changed the title ~~[WIP] MOD-2454: remove aiostream dependency: async_map~~ MOD-2454: remove aiostream dependency: async_map

kramstrom requested a review from freider

October 21, 2024 14:57

kramstrom marked this pull request as ready for review

October 21, 2024 14:57

kramstrom added 2 commits

October 21, 2024 17:08


          raise different exception

31e4ff3

fix

672d55d

Member

ekzhang commented Oct 22, 2024

Wow, asyncio in python is crazy hard.

kramstrom added 6 commits

October 22, 2024 11:34


          tests

1d72a47


          Merge branch 'main' of github.com:modal-labs/modal-client into kramst…

3089dd8

…rom/mod-2454-remove-aiostream-dependency-async_map


          Merge branch 'main' of github.com:modal-labs/modal-client into kramst…

ae71793

…rom/mod-2454-remove-aiostream-dependency-async_map


          cancellation errors

3b2cf99


          queue maxsize

62cf9f4


          Merge branch 'main' of github.com:modal-labs/modal-client into kramst…

3dc129d

…rom/mod-2454-remove-aiostream-dependency-async_map

kramstrom mentioned this pull request

MOD-2454: update async utils #2397

Merged

kramstrom added 4 commits

October 25, 2024 09:15


          Merge branch 'main' of github.com:modal-labs/modal-client into kramst…

566e7ca

…rom/mod-2454-remove-aiostream-dependency-async_map


          Merge branch 'main' of github.com:modal-labs/modal-client into kramst…

1bc20c7

…rom/mod-2454-remove-aiostream-dependency-async_map


          Merge branch 'main' of github.com:modal-labs/modal-client into kramst…

…rom/mod-2454-remove-aiostream-dependency-async_map


          adds

e4abd87

kramstrom mentioned this pull request

MOD-2454: async_map uses async_merge #2422

Merged

Contributor Author

kramstrom commented Nov 1, 2024

Closing in favor of #2422

kramstrom closed this

kramstrom deleted the kramstrom/mod-2454-remove-aiostream-dependency-async_map branch

November 1, 2024 10:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet