Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOD-2454: update async utils #2397

Merged
merged 2 commits into from
Oct 25, 2024
Merged

MOD-2454: update async utils #2397

merged 2 commits into from
Oct 25, 2024

Conversation

kramstrom
Copy link
Contributor

@kramstrom kramstrom commented Oct 24, 2024 •
edited
Loading

Split out non-async_map changes from #2349 to a separate PR

@kramstrom kramstrom requested a review from freider October 24, 2024 13:22
freider
freider approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@freider freider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Maybe add a comment in the merge commit message about what it actually does:

  • make async_zip statically type safe
  • ensure we clean up active tasks when exiting async_zip
  • clean up combined context manager syntax
  • add some more tests

@kramstrom kramstrom merged commit a324784 into main Oct 25, 2024
21 checks passed
@kramstrom kramstrom deleted the kramstrom/mod-2454-update-async-utils branch October 25, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freider freider freider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kramstrom @freider