Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Windows paths in datasets #134

Merged
merged 2 commits into from
Feb 20, 2024
Merged

fix Windows paths in datasets #134

merged 2 commits into from
Feb 20, 2024

Conversation

martinschorb
Copy link
Contributor

addresses #132

Martin Schorb and others added 2 commits February 20, 2024 12:56
@martinschorb
Copy link
Contributor Author

this turned out to be rather easy. I have tested the projects using cross-validation from Windows also to other OSes what the unittests cannot do. Also the projects open in the viewer under all OSes.

constantinpape
constantinpape approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@constantinpape constantinpape merged commit 2c377f5 into master Feb 20, 2024
3 checks passed
This was referenced Feb 20, 2024
Closed
Closed
@martinschorb martinschorb deleted the windows_paths branch February 22, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@constantinpape constantinpape constantinpape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinschorb @constantinpape