Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings for Rust 1.83 #1242

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Fix clippy warnings for Rust 1.83 #1242

merged 2 commits into from
Nov 29, 2024

Conversation

wks
Copy link
Collaborator

@wks wks commented Nov 29, 2024

Clippy 1.83 produces some new warnings:

  • needless_lifetimes is extended to suggest eliding impl lifetimes.
  • empty_line_after_doc_comments is added to the suspicious group.

@wks wks requested a review from qinsoon November 29, 2024 04:06
qinsoon
qinsoon approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@wks wks enabled auto-merge November 29, 2024 04:53
@wks wks added this pull request to the merge queue Nov 29, 2024
Merged via the queue into mmtk:master with commit 5bc6ce5 Nov 29, 2024
31 of 33 checks passed
@wks wks deleted the fix/clippy-1.83 branch November 29, 2024 06:17
@qinsoon qinsoon mentioned this pull request Dec 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2024
@qinsoon
Fix warnings for lifetime in MmapAnnotation impl (#1244)
3d7bc11 
#1242 fixed most similar issues in
the repo, but #1236 introduced
`MmapAnnotation` and introduced a new warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinsoon qinsoon qinsoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wks @qinsoon