Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings for lifetime in MmapAnnotation impl #1244

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix warnings for lifetime in MmapAnnotation impl #1244

merged 1 commit into from
Dec 2, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Dec 1, 2024 •
edited
Loading

#1242 fixed most similar issues in the repo, but #1236 introduced MmapAnnotation and introduced a new warning.

@qinsoon qinsoon force-pushed the mmap-annotation-lifetime branch from afe1bb2 to 3bc5015 Compare December 1, 2024 23:51
@qinsoon qinsoon requested a review from wks December 2, 2024 00:52
wks
wks approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wks wks added this pull request to the merge queue Dec 2, 2024
Merged via the queue into mmtk:master with commit 3d7bc11 Dec 2, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wks wks wks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qinsoon @wks