Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance Statistics #869

Merged
merged 44 commits into from
Jan 31, 2024
Merged

Instance Statistics #869

merged 44 commits into from
Jan 31, 2024

Conversation

Sjmarf
Copy link
Member

@Sjmarf Sjmarf commented Jan 21, 2024

Added a "Details" tab to the Instances page, which is similar to the community Statistics tab. In addition to the instance stats, some of the instance's preferences are also shown. Which preferences are shown is dependent on whether Developer Mode is enabled or not. Let me know if you disagree with any of these choices.

Statistics Dev Mode Disabled Dev Mode Enabled

Other changes

  • Added community creation date to Community Stats, and refactored CommunityStatsView
  • Refactored UserView a little (no UI changes)

@Sjmarf Sjmarf added the enhancement New feature or request label Jan 21, 2024
@Sjmarf Sjmarf mentioned this pull request Jan 21, 2024
@Sjmarf Sjmarf mentioned this pull request Jan 22, 2024
@Sjmarf Sjmarf marked this pull request as ready for review January 27, 2024 11:33
@Sjmarf Sjmarf requested a review from a team as a code owner January 27, 2024 11:33
@Sjmarf Sjmarf requested review from JakeShirley and mormaer and removed request for a team January 27, 2024 11:33
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I do think the detailed instance info should be visible even when dev mode is off--I think anybody who's actually browsing through an instance info page is going to want to see all the info we can give them

Mlem/Views/Shared/Instance/InstanceStatsView.swift Outdated Show resolved Hide resolved
@Sjmarf
Copy link
Member Author

Sjmarf commented Jan 28, 2024

I do think the detailed instance info should be visible even when dev mode is off--I think anybody who's actually browsing through an instance info page is going to want to see all the info we can give them

Here's my reasoning for why I hid certain settings:

  • "Default Feed" could confuse the average user, because it only applies to Lemmy-ui and not to Mlem. Instead of hiding "Default Feed", I suppose another option would be to add an info.circle tooltip that clarifies it?
  • "Federation Signed Fetch" is a technical option - I barely know what it does, but some instances have it enabled and some don't. 99% of our users won't care about this, so I hid it.
  • I hid the slur filter itself for non-dev accounts because some instances use it to block what I assume is illegal content. lemmy.world has URLs in there, and a string of base-64 that's probably a hash/token for something. What's your opinion on this?

I agree it makes sense to always show the other currently hidden settings though ("Show Mod names in Modlog", "Applications email admins" and "Reports email admins")

@EricBAndrews
Copy link
Member

We could maybe hide those in an "advanced" disclosure group--an instance admin or someone might still want to see them, but I agree that it doesn't make sense to put them top-level for the average user. Alternatively we can rename "developer mode" to "power user mode" or something similar, since "developer" carries the implication that the option will only reveal things that are salient to Mlem developers.

Re: default feed, what if we just label it "Default Feed (Desktop)"?

@Sjmarf
Copy link
Member Author

Sjmarf commented Jan 28, 2024

Re: default feed, what if we just label it "Default Feed (Desktop)"?

Sure, sounds good 👍

To be honest we could just not show the Federation Signed Fetch at all... I'm yet to find an instance that has it enabled. That just leaves the question of what to do with the slur filter. Just show the option to reveal it all of the time?

@Sjmarf Sjmarf added this to the v1.2 milestone Jan 29, 2024
@EricBAndrews
Copy link
Member

Slur filter is publicly available information, so I don't think it's really on us to decide whether it's something we should expose or not. It might be worth putting some clickwrap on it to the effect of "this is a regex for detecting slurs, so it's probably going to contain some pretty nasty language" just to be safe.

@Sjmarf
Copy link
Member Author

Sjmarf commented Jan 30, 2024

Done 👍

@Sjmarf Sjmarf enabled auto-merge (squash) January 30, 2024 20:14
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, other than that LGTM 👍

Mlem/Views/Shared/Instance/InstanceDetailsView.swift Outdated Show resolved Hide resolved
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Sjmarf Sjmarf merged commit b3b0a61 into dev Jan 31, 2024
4 checks passed
@Sjmarf Sjmarf deleted the sjmarf/instance-stats branch January 31, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants