-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instance Statistics #869
Instance Statistics #869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I do think the detailed instance info should be visible even when dev mode is off--I think anybody who's actually browsing through an instance info page is going to want to see all the info we can give them
Here's my reasoning for why I hid certain settings:
I agree it makes sense to always show the other currently hidden settings though ("Show Mod names in Modlog", "Applications email admins" and "Reports email admins") |
We could maybe hide those in an "advanced" disclosure group--an instance admin or someone might still want to see them, but I agree that it doesn't make sense to put them top-level for the average user. Alternatively we can rename "developer mode" to "power user mode" or something similar, since "developer" carries the implication that the option will only reveal things that are salient to Mlem developers. Re: default feed, what if we just label it "Default Feed (Desktop)"? |
Sure, sounds good 👍 To be honest we could just not show the Federation Signed Fetch at all... I'm yet to find an instance that has it enabled. That just leaves the question of what to do with the slur filter. Just show the option to reveal it all of the time? |
Slur filter is publicly available information, so I don't think it's really on us to decide whether it's something we should expose or not. It might be worth putting some clickwrap on it to the effect of "this is a regex for detecting slurs, so it's probably going to contain some pretty nasty language" just to be safe. |
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo, other than that LGTM 👍
Co-authored-by: Eric Andrews <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Added a "Details" tab to the Instances page, which is similar to the community Statistics tab. In addition to the instance stats, some of the instance's preferences are also shown. Which preferences are shown is dependent on whether Developer Mode is enabled or not. Let me know if you disagree with any of these choices.
Other changes
CommunityStatsView
UserView
a little (no UI changes)