Search Instances #873
Merged
Search Instances #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sjmarf
requested review from
mormaer and
EricBAndrews
and removed request for
a team
EricBAndrews
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Looks good! A couple nits, and I also noticed some inconsistent behavior around searching:
Screen.Recording.2024-01-31.at.4.44.29.PM.mov
It's minor enough that I don't see a need to hold up the merge to resolve it, but if we merge with this behavior still present it's worth opening an issue.
|
Nice catch! Should be fixed now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is built ontop of #869. Drafting until that PR is merged.
Instance Search
Adds an "instances" tab to search. When the app opens, the instance list is downloaded from https://github.com/mlemgroup/mlem-stats. That repo has a GH action set up to refresh the data every 24 hours. So if an instance changes their avatar or version number, it could take 48 hours for it to be updated in Mlem (lemmyverse's 24h maximum, followed by our 24h maximum). Instances that have a negative score, have less than 20 users or are censured on fediseer are excluded. This cuts the list down from ~850 to ~160 instances.
The search tab code is a little clunky, and will need to be re-done as a whole at some point. I'll do that post-iOS 17, at the same time I do post searching probably.
What do we do about NSFW instances? There's currently no way to tell if an instance is NSFW-only, although there's a PR open for this.