Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.19 Non-Breaking Compatibility and Deprecation Comments #787

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

EricBAndrews
Copy link
Member

@EricBAndrews EricBAndrews commented Dec 1, 2023

Built on top of #786.

Modified API types to accord with 0.19, and added lots of comments for 0.18 deprecation and 0.19 support.

Closes #761

@EricBAndrews EricBAndrews force-pushed the eric/0.19-compatibility-2 branch from d404fb0 to 71b20cc Compare December 1, 2023 22:30
@EricBAndrews EricBAndrews marked this pull request as ready for review December 1, 2023 22:30
@EricBAndrews EricBAndrews requested a review from a team as a code owner December 1, 2023 22:30
@EricBAndrews EricBAndrews requested review from WestonHanners and mormaer and removed request for a team December 1, 2023 22:30
@EricBAndrews EricBAndrews changed the title 0.19 Compatibility Comments 0.19 Non-Breaking Compatibility and Deprecation Comments Dec 1, 2023
Copy link
Member

@Sjmarf Sjmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricBAndrews EricBAndrews force-pushed the eric/0.19-compatibility-2 branch from 71b20cc to d007306 Compare December 4, 2023 20:31
@EricBAndrews EricBAndrews merged commit 77b9cd0 into dev Dec 5, 2023
4 checks passed
@EricBAndrews EricBAndrews deleted the eric/0.19-compatibility-2 branch December 5, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.19] Inbox compatibility
2 participants