0.19 Non-Breaking Compatibility and Deprecation Comments (#787)

Mlem/API/Models/APIErrorResponse.swift

@@ -7,6 +7,8 @@
 
 import Foundation
 
+// TODO: 0.19 support add all the error types (https://github.com/LemmyNet/lemmy-js-client/blob/b2edfeeaffd189a51150362cc8ead03c65ee2652/src/types/LemmyErrorType.ts)
+
 struct APIErrorResponse: Decodable {
     let error: String
 }

Mlem/API/Models/Comments/APICommentReplyView.swift

@@ -17,6 +17,8 @@ struct APICommentReplyView: Decodable {
     let recipient: APIPerson
     let counts: APICommentAggregates
     let creatorBannedFromCommunity: Bool
+    let creatorIsModerator: Bool? // TODO: 0.18 deprecation make this field non-optional
+    let creatorIsAdmin: Bool? // TODO: 0.18 deprecation make this field non-optional
     let subscribed: APISubscribedStatus
     let saved: Bool
     let creatorBlocked: Bool

Mlem/API/Models/Comments/APICommentView.swift

@@ -15,6 +15,8 @@ struct APICommentView: Decodable, APIContentViewProtocol {
     let community: APICommunity
     let counts: APICommentAggregates
     let creatorBannedFromCommunity: Bool
+    let creatorIsModerator: Bool? // TODO: 0.18 deprecation make this field non-optional
+    let creatorIsAdmin: Bool? // TODO: 0.18 deprecation make this field non-optional
     let subscribed: APISubscribedStatus
     let saved: Bool
     let creatorBlocked: Bool

Mlem/API/Models/Person/APIPerson.swift

@@ -23,7 +23,7 @@ struct APIPerson: Decodable, Identifiable, Hashable {
     let deleted: Bool
     let sharedInboxUrl: String?
     let matrixUserId: String?
-    let admin: Bool? // this is no longer returned on beehaw...
+    let admin: Bool? // TODO: 0.18 deprecation remove this field
     let botAccount: Bool
     let banExpires: Date?
     let instanceId: Int

Mlem/API/Models/Person/APIPersonMentionView.swift

@@ -18,6 +18,8 @@ struct APIPersonMentionView: Decodable {
     let recipient: APIPerson
     let counts: APICommentAggregates
     let creatorBannedFromCommunity: Bool
+    let creatorIsModerator: Bool? // TODO: 0.18 deprecation make this field non-optional
+    let creatorIsAdmin: Bool? // TODO: 0.18 deprecation make this field non-optional
     let subscribed: APISubscribedStatus
     let saved: Bool
     let creatorBlocked: Bool

Mlem/API/Models/Person/APIPersonView.swift

@@ -11,5 +11,5 @@ import Foundation
 struct APIPersonView: Decodable {
     let person: APIPerson
     let counts: APIPersonAggregates
-    let isAdmin: Bool?
+    let isAdmin: Bool? // TODO: 0.18 deprecation make this field non-optional
 }

Mlem/API/Models/Posts/APIPostView.swift

@@ -13,8 +13,8 @@ struct APIPostView: Decodable, APIContentViewProtocol {
     let creator: APIPerson
     let community: APICommunity
     let creatorBannedFromCommunity: Bool
-    // TODO: 0.18 Deprecation make this field non-optional
-    let creatorIsModerator: Bool?
+    let creatorIsModerator: Bool? // TODO: 0.18 deprecation make this field non-optional
+    let creatorIsAdmin: Bool? // TODO: 0.18 deprecation make this field non-optional
     var counts: APIPostAggregates
     let subscribed: APISubscribedStatus
     let saved: Bool

Mlem/API/Models/Site/APILocalSiteRateLimit.swift

@@ -28,4 +28,5 @@ struct APILocalSiteRateLimit: Decodable {
     let searchPerSecond: Int
     let published: Date
     let updated: Date?
+    // TODO: 0.19 support add import_user_settings and import_user_settings_per_second
 }

Mlem/API/Requests/Comment/CreateComment.swift

@@ -20,7 +20,7 @@ struct CreateCommentRequest: APIPostRequest {
         let post_id: Int
         let parent_id: Int?
         let language_id: Int?
-        let form_id: String?
+        let form_id: String? // TODO: 0.18 deprecation remove this field
         let auth: String
     }
 
@@ -47,5 +47,5 @@ struct CreateCommentRequest: APIPostRequest {
 struct CommentResponse: Decodable {
     let commentView: APICommentView
     let recipientIds: [Int]
-    let formId: String?
+    let formId: String? // TODO: 0.18 deprecation remove this field
 }

Mlem/API/Requests/Comment/GetComments.swift

@@ -27,6 +27,7 @@ struct GetCommentsRequest: APIGetRequest {
         communityName: String?,
         parentId: Int?,
         savedOnly: Bool?
+        // TODO: 0.19 support add liked_only and disliked_only query params
     ) throws {
         self.instanceURL = try session.instanceUrl
         var queryItems: [URLQueryItem] = [

Mlem/API/Requests/Messages/GetPrivateMessages.swift

@@ -20,10 +20,11 @@ struct GetPrivateMessagesRequest: APIGetRequest {
         page: Int?,
         limit: Int?,
         unreadOnly: Bool
+        // TODO: 0.19 support add creator_id? field
     ) throws {
         self.instanceURL = try session.instanceUrl
-        self.queryItems = [
-            .init(name: "auth", value: try session.token),
+        self.queryItems = try [
+            .init(name: "auth", value: session.token),
             .init(name: "page", value: page?.description),
             .init(name: "limit", value: limit?.description),
             .init(name: "unread_only", value: String(unreadOnly))

Mlem/API/Requests/Post/GetPosts.swift

@@ -25,6 +25,7 @@ struct GetPostsRequest: APIGetRequest {
         limit: Int? = nil,
         savedOnly: Bool? = nil,
         communityName: String? = nil
+        // TODO: 0.19 support add liked_only and disliked_only fields
     ) throws {
         self.instanceURL = try session.instanceUrl
         var queryItems: [URLQueryItem] = [

Mlem/API/Requests/Post/MarkPostRead.swift

@@ -18,6 +18,7 @@ struct MarkPostReadRequest: APIPostRequest {
         let post_id: Int
         let read: Bool
         let auth: String
+        // TODO: 0.19 support add post_ids? field
     }
 
     init(

Mlem/API/Requests/User/DeleteUser.swift

@@ -7,6 +7,7 @@
 
 import Foundation
 
+// TODO: 0.18 deprecation remove this struct
 struct LegacyDeleteAccountRequest: APIPostRequest {
     typealias Response = DeleteAccountResponse
 
@@ -33,7 +34,7 @@ struct LegacyDeleteAccountRequest: APIPostRequest {
 }
 
 struct DeleteAccountRequest: APIPostRequest {
-    typealias Response = DeleteAccountResponse
+    typealias Response = SuccessResponse
 
     let instanceURL: URL
     let path = "user/delete_account"

Mlem/Enums/Settings/CommentSortType.swift

@@ -8,7 +8,7 @@
 import Foundation
 
 // lemmy_db_schema::CommentSortType
-// TODO: this is not accurate to the Lemmy enum, active -> hot, and "old" is missing
+// TODO: this is not accurate to the Lemmy enum, "controversial" is missing
 enum CommentSortType: String, Codable, CaseIterable, Identifiable {
     case top, hot, new, old
 

Mlem/Models/PictrsImageModel.swift

@@ -25,6 +25,7 @@ struct PictrsImageModel {
         case uploaded(file: PictrsFile?)
         case failed(String?)
     }
+
     var image: Image?
     var state: UploadState = .waiting
 }

Mlem/Repositories/InboxRepository.swift

@@ -46,6 +46,8 @@ class InboxRepository {
                 recipient: reply.recipient,
                 counts: updatedCommentView.counts,
                 creatorBannedFromCommunity: updatedCommentView.creatorBannedFromCommunity,
+                creatorIsModerator: false,
+                creatorIsAdmin: false,
                 subscribed: updatedCommentView.subscribed,
                 saved: updatedCommentView.saved,
                 creatorBlocked: updatedCommentView.creatorBlocked,
@@ -96,6 +98,8 @@ class InboxRepository {
                 recipient: mention.recipient,
                 counts: updatedCommentView.counts,
                 creatorBannedFromCommunity: updatedCommentView.creatorBannedFromCommunity,
+                creatorIsModerator: false,
+                creatorIsAdmin: false,
                 subscribed: updatedCommentView.subscribed,
                 saved: updatedCommentView.saved,
                 creatorBlocked: updatedCommentView.creatorBlocked,

Mlem/Views/Shared/Links/User/UserLabelView.swift

@@ -268,6 +268,7 @@ struct UserLinkViewPreview: PreviewProvider {
             community: community,
             creatorBannedFromCommunity: false,
             creatorIsModerator: false,
+            creatorIsAdmin: false,
             counts: postVotes,
             subscribed: .notSubscribed,
             saved: false,

Mlem/Views/Tabs/Profile/User View.swift

@@ -381,6 +381,7 @@ struct UserViewPreview: PreviewProvider {
             community: community,
             creatorBannedFromCommunity: false,
             creatorIsModerator: false,
+            creatorIsAdmin: false,
             counts: postVotes,
             subscribed: .notSubscribed,
             saved: false,