FIx issue where swipey view actions publishes updates on background t… #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boscojwho
requested review from
JakeShirley and
EricBAndrews
and removed request for
a team
EricBAndrews
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- EditorTracker changes published on background thread #682, HierarchicalComment updates on background thread #693
Pull Request Information
About this Pull Request
Fixes issue where
SwipeAction.actionmay attempt to publish changes on background thread, instead of main thread.~ For example: Theoretically, we could have a swipe action that's mapped to upvote/downvote (on low power mode) or an automated bug report action that doesn't show any UI. These actions may not necessarily need a
.userInitiatedpriority, and SwipeyView wouldn't know and shouldn't have to deal with that.SwiftUI.ButtonAPI pattern (albeit a bit annoying at call site), where call site wraps async calls in an inline synchronous closure.Screenshots and Videos
No UI changes.