FIx issue where swipey view actions publishes updates on background t… (

#694)
mlemgroup · Oct 4, 2023 · 05ef83c · 05ef83c
1 parent 78351b1
commit 05ef83c
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 12 deletions.
diff --git a/Mlem/Extensions/Swipey Actions.swift b/Mlem/Extensions/Swipey Actions.swift
@@ -18,7 +18,7 @@ public struct SwipeAction {
 
     let symbol: Symbol
     let color: Color
-    let action: () async -> Void
+    let action: () -> Void
 }
 
 // MARK: -
@@ -201,9 +201,7 @@ struct SwipeyView: ViewModifier {
 
         reset()
 
-        Task(priority: .userInitiated) {
-            await swipeAction(at: finalDragPosition)?.action()
-        }
+        swipeAction(at: finalDragPosition)?.action()
     }
 
     private func reset() {

diff --git a/Mlem/Views/Shared/Comments/Comment Item.swift b/Mlem/Views/Shared/Comments/Comment Item.swift
@@ -227,7 +227,11 @@ extension CommentItem {
         SwipeAction(
             symbol: .init(emptyName: emptyVoteSymbolName, fillName: upvoteSymbolName),
             color: .upvoteColor,
-            action: upvote
+            action: {
+                Task {
+                    await upvote()
+                }
+            }
         )
     }
 
@@ -236,23 +240,35 @@ extension CommentItem {
         return SwipeAction(
             symbol: .init(emptyName: emptyDownvoteSymbolName, fillName: downvoteSymbolName),
             color: .downvoteColor,
-            action: downvote
+            action: {
+                Task {
+                    await downvote()
+                }
+            }
         )
     }
 
     var saveSwipeAction: SwipeAction {
         SwipeAction(
             symbol: .init(emptyName: emptySaveSymbolName, fillName: saveSymbolName),
             color: .saveColor,
-            action: saveComment
+            action: {
+                Task {
+                    await saveComment()
+                }
+            }
         )
     }
 
     var replySwipeAction: SwipeAction? {
         SwipeAction(
             symbol: .init(emptyName: emptyReplySymbolName, fillName: replySymbolName),
             color: .accentColor,
-            action: replyToCommentAsyncWrapper
+            action: {
+                Task {
+                    await replyToCommentAsyncWrapper()
+                }
+            }
         )
     }
 

diff --git a/Mlem/Views/Shared/Posts/Feed Post.swift b/Mlem/Views/Shared/Posts/Feed Post.swift
@@ -433,7 +433,11 @@ extension FeedPost {
         return SwipeAction(
             symbol: .init(emptyName: emptySymbolName, fillName: fullSymbolName),
             color: .upvoteColor,
-            action: upvotePost
+            action: {
+                Task {
+                    await upvotePost()
+                }
+            }
         )
     }
 
@@ -446,7 +450,11 @@ extension FeedPost {
         return SwipeAction(
             symbol: .init(emptyName: emptySymbolName, fillName: fullSymbolName),
             color: .downvoteColor,
-            action: downvotePost
+            action: {
+                Task {
+                    await downvotePost()
+                }
+            }
         )
     }
 
@@ -457,7 +465,11 @@ extension FeedPost {
         return SwipeAction(
             symbol: .init(emptyName: emptySymbolName, fillName: fullSymbolName),
             color: .saveColor,
-            action: savePost
+            action: {
+                Task {
+                    await savePost()
+                }
+            }
         )
     }
 

diff --git a/Mlem/Views/Tabs/Search/CommunityResultView.swift b/Mlem/Views/Tabs/Search/CommunityResultView.swift
@@ -23,7 +23,11 @@ struct CommunityResultView: View {
         return SwipeAction(
             symbol: .init(emptyName: emptySymbolName, fillName: fullSymbolName),
             color: community.subscribed ? .red : .green,
-            action: subscribe
+            action: {
+                Task {
+                    await subscribe()
+                }
+            }
         )
     }