Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scrolling regression #677

Merged
merged 3 commits into from
Oct 1, 2023

rebased

84919ae
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fixed scrolling regression #677

rebased
84919ae
Select commit
Loading
Failed to load commit list.
GitHub Actions / Xcode test results succeeded Oct 1, 2023 in 0s

Xcode test results

Testing project Mlem with scheme Mlem

Summary

TotalSuccess PassedFailure FailedSkipped SkippedExpected Failure Expected Failure⏱️ Time
53530000.75s

Test Summary

MlemTests

  • Device: iPhone 14, 16.4 (20E247)
  • SDK: Simulator - iOS 16.4, 16.4
TestTotalSuccessFailureSkippedExpected Failure
test-class CommunityListModelTests1010000
test-class InstanceMetadataParserTests22000
test-class LemmyURLTests33000
test-class MlemTests22000
test-class PersistenceRepositoryTests2121000
test-class RoutableTests1010000
test-class SiteVersionTests33000
test-class TimestampedValueTests22000

Failure Failures

All tests passed 🎉

Details

Test Details

MlemTestsback

CommunityListModelTests back

SuccessFailureSkippedExpected Failure⏱️
10 (100%)0 (0%)0 (0%)0 (0%)0.15s
Successtest-method testAllSectionsOrder()
Successtest-method testCorrectCommunitiesAreReturnedForSections()
Successtest-method testDuplicatesAreHandledCorrectly()
Successtest-method testFailedSubscriptionUpdate()
Successtest-method testInitialState()
Successtest-method testLoadingWithNoSubscriptionsOrFavourites()
Successtest-method testLoadingWithSubscriptionAndFavorite()
Successtest-method testModelRespondsToFavorites()
Successtest-method testSubscribedStatusIsCorrect()
Successtest-method testSuccessfulSubscriptionUpdate()

InstanceMetadataParserTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testParserHandlesExpectedData()
Successtest-method testParserIsNotReliantOnHeaderFieldOrder()

LemmyURLTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testHandlesEncodedURL()
Successtest-method testHandlesUnencodedURL()
Successtest-method testHandlesValidURL()

MlemTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.59s
Successtest-method testExample()
Successtest-method testPerformanceExample()

PersistenceRepositoryTests back

SuccessFailureSkippedExpected Failure⏱️
21 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testAccountsWithoutTokensAreOmitted()
Successtest-method testLatestInstanceMetaDataIsPreferred()
Successtest-method testLoadAccounts()
Successtest-method testLoadEasterFlagsWithoutValues()
Successtest-method testLoadEasterFlagsWithValues()
Successtest-method testLoadFavoriteCommunitiesWithoutValues()
Successtest-method testLoadFavoriteCommunitiesWithValues()
Successtest-method testLoadInstanceMetadataWithoutValues()
Successtest-method testLoadInstanceMetadataWithValues()
Successtest-method testLoadKeywordsWithoutValues()
Successtest-method testLoadKeywordsWithValues()
Successtest-method testLoadLayoutWidgetsWithoutValues()
Successtest-method testLoadLayoutWidgetsWithValues()
Successtest-method testLoadRecentSearchesWithoutValues()
Successtest-method testLoadRecentSearchesWithValues()
Successtest-method testSaveAccounts()
Successtest-method testSaveEasterFlags()
Successtest-method testSaveFavoriteCommunities()
Successtest-method testSaveFilteredKeywords()
Successtest-method testSaveRecentSearches()
Successtest-method testSecureTokensAreNotWrittenToDisk()

RoutableTests back

SuccessFailureSkippedExpected Failure⏱️
10 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testMockRoute_handlesNestedAssociatedValueEnumCase()
Successtest-method testMockRoute_handlesNestedUnsupportedValue()
Successtest-method testMockRoute_handlesNoAssociatedValueEnumCase()
Successtest-method testMockRoute_handlesNonNestedAssociatedValueEnumCase()
Successtest-method testMockRoute_handlesUnsupportedValue()
Successtest-method testNavigationRouteHandlesDataValue()
Successtest-method testNavigationRouteHandlesNonNestedAssociatedValueEnumCase()
Successtest-method testSettingsRouteHandlesNestedAssociatedValueEnumCase()
Successtest-method testSettingsRouteHandlesNoAssociatedValueEnumCase()
Successtest-method testSettingsRouteHandlesNonNestedAssociatedValueEnumCase()

SiteVersionTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testComparisons()
Successtest-method testStringDescription()
Successtest-method testStringInitializer()

TimestampedValueTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testValueIdentifiesAsNotStaleCorrectly()
Successtest-method testValueIdentifiesAsStaleCorrectly()