Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed scrolling regression #677

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Fixed scrolling regression #677

merged 3 commits into from
Oct 1, 2023

Conversation

EricBAndrews
Copy link
Member

Checklist

  • I have read CONTRIBUTING.md
  • I have described what this PR contains
  • This PR addresses one or more open issues that were assigned to me
  • If this PR alters the UI, I have attached pictures/videos

Pull Request Information

This PR addresses a scrolling regression where scrolling back up the feed was choppy.

@EricBAndrews EricBAndrews requested a review from a team as a code owner September 30, 2023 15:18
@EricBAndrews EricBAndrews requested review from mormaer and ShadowJonathan and removed request for a team September 30, 2023 15:18
@Sjmarf
Copy link
Contributor

Sjmarf commented Sep 30, 2023

Still a little choppy for me 🤔

@Sjmarf
Copy link
Contributor

Sjmarf commented Sep 30, 2023

trim.430F8034-7EA9-4ABF-A982-2B684DBF5026.MOV

@EricBAndrews EricBAndrews enabled auto-merge (squash) October 1, 2023 04:12
boscojwho
boscojwho approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@boscojwho boscojwho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:

  • No sizing regressions on iPad.
  • Quite performant on 2018 iPad Pro with lots of image posts.

@EricBAndrews EricBAndrews merged commit 8bf08b3 into dev Oct 1, 2023
4 checks passed
@EricBAndrews EricBAndrews deleted the eric/scroll-fix branch October 1, 2023 06:48
boscojwho added a commit that referenced this pull request Oct 11, 2023
@boscojwho
Fixed scrolling regression (#677)
5121d7c 
Commit:
8bf08b3 [8bf08b3]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boscojwho boscojwho boscojwho approved these changes

@mormaer mormaer Awaiting requested review from mormaer mormaer is a code owner automatically assigned from mlemgroup/mlem-dev-team

@ShadowJonathan ShadowJonathan Awaiting requested review from ShadowJonathan ShadowJonathan is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EricBAndrews @Sjmarf @boscojwho