Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Official Community" link, Improve navigation routing pattern #656

Merged
merged 34 commits into from
Oct 11, 2023
Merged

Fix "Official Community" link, Improve navigation routing pattern #656

merged 34 commits into from
Oct 11, 2023

Conversation

boscojwho
Copy link
Contributor

@boscojwho boscojwho commented Sep 27, 2023 •
edited
Loading

Checklist

Pull Request Information

About this Pull Request

  • FIX: "Official Community" link in Settings now opens in app again (not in-app browser).
  • Streamlines navigation routes logic and naming.

Screenshots and Videos

  • No UI changes.

Additional Context

  • Next step: Considering putting all /Navigation logic in an embedded SPM package.

@boscojwho
- Remove SettingsRouter.
706261d 
- Move that logic into HandleLemmyLinks.
@boscojwho
- Merge SettingsRoutes into NavigationRoutes.
6ff9b6c 
- Declare settings routes that wrap semantic routes as a data value.
@boscojwho
Rename navigation types for clarity.
ec4f17e
@boscojwho
Rename vars for clarity.
1555465
@boscojwho
- Add DestinationValue.
a282bf4 
- Documentation.
- Move some files.
- Update tests.
@boscojwho
- Move OnboardingRoutes to navigation directory to separate views f…
78ca37c 
…rom the data that drives the presentation of views.

- Add documentation.
@boscojwho boscojwho requested a review from a team as a code owner September 27, 2023 06:16
@boscojwho boscojwho requested review from WestonHanners and JakeShirley and removed request for a team September 27, 2023 06:16
@boscojwho boscojwho changed the title Bosco/improve navigation routing pattern Fix "Official Community" link, Improve navigation routing pattern Sep 27, 2023
@boscojwho boscojwho mentioned this pull request Sep 27, 2023
Closed
EricBAndrews
EricBAndrews requested changes Sep 30, 2023
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Official Community link still does not work if you connect using an account not registered on lemmy.world. That URL needs to adapt to the host of the user.

Other than that, looks good!

@boscojwho
Copy link
Contributor Author

boscojwho commented Oct 1, 2023 •
edited
Loading

Official Community link still does not work if you connect using an account not registered on lemmy.world. That URL needs to adapt to the host of the user.

Other than that, looks good!

@EricBAndrews
Interesting:

  • This happens on beta-1.0.1-RC-2 [Aug. 9] (ff5d8f7)
  • Tested with my account on lemmy.world/lemmy.ca (opens in-app) and test.mlem.jo.wtf (opens in browser).
  • I'm not familiar with the Link Resolver, is this something related to whether an instance is federated with lemmy.ml, where our community page is hosted?

EricBAndrews
EricBAndrews approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@EricBAndrews
Copy link
Member

Federation is the likely culprit. Until we have guest mode and can use that as a fallback, let's go with it as-is.

boscojwho added 14 commits October 3, 2023 23:53
@boscojwho
Merge branch 'dev' into bosco/improve-navigation-routing-pattern
d9e57a9 
# Conflicts:
#	Mlem.xcodeproj/project.pbxproj
#	Mlem/Views/Tabs/Search/Search View.swift
#	Mlem/Views/Tabs/Settings/Components/Views/About/LicensesView.swift
@boscojwho
Fix Xcode project directory file ref (OnboardingRoutes.swift).
7fad834
@boscojwho
Revert "Fix Xcode project directory file ref (OnboardingRoutes.swift)."
c8b5ce0 
This reverts commit 7fad834.
@boscojwho
Revert "Merge branch 'dev' into bosco/improve-navigation-routing-patt…
7b25276 
…ern"

This reverts commit d9e57a9, reversing
changes made to 78ca37c.
@boscojwho
resolved email verification crash (#659) [f643b13]
e9d3864
@boscojwho
Fix widget wizard rect bug (#668)
ebdbdaa 
Commit:
238dac3
@boscojwho
Added updated time display (#678)
dab40ec 
Commit:
b0c0d41 [b0c0d41]
@boscojwho
Fixed scrolling regression (#677)
5121d7c 
Commit:
8bf08b3 [8bf08b3]
@boscojwho
Fix crash when post object originates from link resolver (#669)
7afb20f 
Commit:
15266c0 [15266c0]
@boscojwho
Image uploading (#652)
59b32b0 
Commit:
c4c42c5 [c4c42c5]
@boscojwho
Improved Search (#646)
86c7cdb 
Commit:
876e7c0 [876e7c0]
@boscojwho
Fixed swipey action bad behavior with context menus (#680)
60f039a 
Commit:
a48f3ae [a48f3ae]
@boscojwho
Show error when instance is private (#683)
2dcf7be 
Commit:
6d1a997 [6d1a997]
@boscojwho
Made recent searches be stored per-account (#684)
f322e89 
Commit:
b24e9ca [b24e9ca]
@boscojwho
Fixed default sidebar avatars (#689)
8185f66 
Commit:
1d83d19 [1d83d19]
@boscojwho
Updated account transition (#685)
faa224d 
Commit:
78351b1 [78351b1]
@boscojwho
FIx issue where swipey view actions publishes updates on background t… (
5e91e98 
#694)

Commit:
05ef83c [05ef83c]
@boscojwho
Optimized search view rendering (#695)
46339b0 
Commit:
fb3ebb3 [fb3ebb3]
@boscojwho
Fix info stack alignment (#697)
45bf53b 
Commit:
e19364a [e19364a]
@boscojwho
Allow disabling swipe-up for account switcher (#698)
4eb983f 
Commit:
343ef1c [343ef1c]
@boscojwho
Fixed profile refresh problems (#687)
b6dfa96 
Commit:
583de0c [583de0c]
@boscojwho
Fixed profile refresh problems (#687)
222299e 
Commit:
583de0c [583de0c]
@boscojwho
Avoid search rate limit (#704)
37324b1 
Commit:
c04d3c2 [c04d3c2]
@boscojwho
Fix search home page refresh bug (#706)
3189169 
Commit:
646ee5a [646ee5a]
@boscojwho
Swipe to delete recent search (#703)
16683a0 
Commit:
0b5a75e [0b5a75e]
@boscojwho
fixed compact comments not appropriately displaying vote status (#712)
b19c9c8
@boscojwho
- Fix some build errors.
0df4cf1
@boscojwho
Merge branch 'dev' into bosco/improve-navigation-routing-pattern
d707ccd
@boscojwho boscojwho merged commit 309b4a2 into dev Oct 11, 2023
4 checks passed
@boscojwho boscojwho deleted the bosco/improve-navigation-routing-pattern branch October 11, 2023 07:33
boscojwho added a commit that referenced this pull request Nov 23, 2023
@boscojwho
Fix "Official Community" link, Improve navigation routing pattern (#656)
09187d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBAndrews EricBAndrews EricBAndrews approved these changes

@WestonHanners WestonHanners Awaiting requested review from WestonHanners WestonHanners is a code owner automatically assigned from mlemgroup/mlem-dev-team

@JakeShirley JakeShirley Awaiting requested review from JakeShirley JakeShirley is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boscojwho @EricBAndrews