Navigation: SPM local package #657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move that logic into HandleLemmyLinks.
- Declare settings routes that wrap semantic routes as a data value.
- Documentation. - Move some files. - Update tests.
…rom the data that drives the presentation of views. - Add documentation.
- Move some navigation tests over to package.
mormaer
reviewed
Sep 27, 2023
boscojwho
requested review from
WestonHanners and
JakeShirley
and removed request for
a team
|
Looks like CI/CD tools work as expected: Converting this to a PR. |
Yea! I figured we'd start in a small corner of the project that doesn't really have too many local dependencies. I guess we could create an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Information
About this Pull Request
Moves
Navigationfiles into local SPM package:I set this to draft PR because I haven't looked into/thought about how this might impact our current CI/CD tools or whether we need to adjust those tools.
Additional Notes
I did leave out small portions of Navigation (the actual navigation routes that reference the model/middleware layers) because those local packages don't exist yet.