Fix router lemmy link resolution #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpting to append to `AnyNavigationPath`: - Handler now wraps resolved value in the associated navigation path's route value type. - Also, remove `AnyNavigationPath` conformance for `NavigationPath` because it no longer makes sense.
- Documentation.
boscojwho
requested review from
JakeShirley and
mormaer
and removed request for
a team
mormaer
requested changes
Sep 24, 2023
- Fix where we test for Self in makeRoute. - Add tests for `Routable` logic. - Add documentation.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- Addresses * Community links in post bodies do nothing #632
Pull Request Information
About this Pull Request
Fixes issue where community links do nothing because navigation router didn't recognize them as a valid navigation route.
NavigationRouterwas accepting raw data values fromHandleLemmyLinkResolution, which is no longer supported.Screenshots and Videos
No UI changes.
Additional Context
Will follow up shortly with another PR that streamlines navigation routes a bit more.