Code

Boscojwho/hoist navigation dismiss#611

Code

Merged

boscojwho merged 38 commits intomlemgroup:bosco/tab-bar-navigationmlemgroup/mlem:bosco/tab-bar-navigationfrom boscojwho:boscojwho/hoist-navigation-dismissboscojwho/mlem:boscojwho/hoist-navigation-dismissCopy head branch name to clipboardSep 15, 2023

+609-115

Commits

Commits on Sep 9, 2023

• - Add navigation routes for non-settings paths.

  boscojwho

  committed
  c06bc03

• - Add environment value for navigation routes.

  boscojwho

  committed
  c170c4d

• - Add AnyNavigationPath so view modifiers (or anything else) that need a reference to a navigation path can use whatever.

  boscojwho

  committed
  d480761

• - *WIP* Use NavigationRoute enum to configure navigation path.

  boscojwho

  committed
  db27c61

• Use enum route to construct navigation path, where possible.

  Show description for f3316d9
  boscojwho

  committed
  f3316d9

• - Vary what value is passed to NavigationLink based on context.

  boscojwho

  committed
  7b0ae62

• - Move NavigationContext to separate file.

  boscojwho

  committed
  5aaa28f

• - Use navigation router in Inbox/Profile/Search tabs.

  boscojwho

  committed
  0803abe

• - Use navigation router in Settings.

  boscojwho

  committed
  261db18

• - *WIP* Hoist navigation dismiss action to root view.

  boscojwho

  committed
  cce624c

Commits on Sep 12, 2023

• - Add tab bar navigation view modifier.

  boscojwho

  committed
  12a51ad

• - Hoist dismiss action in applicable views.

  boscojwho

  committed
  19c3452

• - Hoist dismiss action in applicable views.

  Show description for 2af9e45
  boscojwho

  committed
  2af9e45

• - Fix issue where navigation stack calls onAppear on root page when attempting tab bar navigation.

  Show description for baefb49
  boscojwho

  committed
  baefb49

• - Initialize navigationSelection using provided selection.

  Show description for 82dfaaa
  boscojwho

  committed
  82dfaaa

• - *WIP* Re-adding scrollToTop/popToSidebar as auxiliary action.

  Show description for 66e8ac0
  boscojwho

  committed
  66e8ac0

• - Fix issue where scroll view proxy didn't propagate down to some child views.

  Show description for b7044ad
  boscojwho

  committed
  b7044ad

• - Only scroll to top if view is root view on navigation stack.

  boscojwho

  committed
  e387088

• - Project cleanup.

  boscojwho

  committed
  dd6155c

• - Move scroll to view to separate file.

  boscojwho

  committed
  c603726

• - Add scroll to top in Inbox.

  boscojwho

  committed
  a01892c

Commits on Sep 13, 2023

• - Add scroll to top in profile view.

  boscojwho

  committed
  68b59cf

• - Add scroll to top in Search view.

  boscojwho

  committed
  ea4a8bf

• - Add scroll to top in settings.

  boscojwho

  committed
  f00a0aa

• - Move scroll reader to Profile tab root.

  Show description for 5131811
  boscojwho

  committed
  5131811

• - Add documentation.

  boscojwho

  committed
  9e1c3a7

• - lint

  boscojwho

  committed
  caa199a

• - Add scroll to top in sidebar.

  boscojwho

  committed
  63294ed

• - Don't need scroll to view.

  boscojwho

  committed
  bc3b961

• - Fix crash that may occur when a navigation view is presented as a sheet view (sheets don't participate in tab bar navigation).

  boscojwho

  committed
  06d42e5

• - *WIP* tap tab to show/hide sidebar on regular horizontal size class.

  boscojwho

  committed
  a649548

Commits on Sep 14, 2023

• - *WIP* Fix issue where if user peeks at previous view but cancels (drag gesture), navigation breaks because SwiftUI doesn't call onAppear again on top view.

  boscojwho

  committed
  f377a3a

• - Don't remove path action when performing it, let it be removed when view disappears.

  boscojwho

  committed
  24a238a

• - Fix issue where if user cancels drag to go back action, tab navigation no longer works because it lost reference to dismiss action.

  boscojwho

  committed
  659b399

Commits on Sep 15, 2023

• - Play haptic feedback prior to performing navigation action.

  boscojwho

  committed
  2a52465

• Merge branch 'boscojwho/tab-navigate-sidebar-ipad' into boscojwho/hoist-navigation-dismiss-action

  Show description for d7a83a5
  boscojwho

  committed
  d7a83a5

• Merge branch 'dev' into boscojwho/hoist-navigation-dismiss

  Show description for ba871e3
  boscojwho

  committed
  ba871e3

• Merge branch 'bosco/tab-bar-navigation' into boscojwho/hoist-navigation-dismiss

  boscojwho

  authored
  a480864