Boscojwho/hoist navigation dismiss #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eed a reference to a navigation path can use whatever.
Note: - Exception is in sidebar.
- Add tab bar navigation to Inbox/Profile/Search. Note: - Need to fix Feed tab navigation.
…ttempting tab bar navigation. - Add debug print in dismiss action.
- Fix issue where navigationSelection was not the same as selection on init. - Remove navigation selection state from ContentView.
Note: - Scroll to top appeared seems broken.
…ld views. - Remove unused code. - Add documentation.
- Only scroll to top in user view if it is root view.
…heet view (sheets don't participate in tab bar navigation).
…rag gesture), navigation breaks because SwiftUI doesn't call onAppear again on top view.
… view disappears.
…ion no longer works because it lost reference to dismiss action.
…st-navigation-dismiss-action * boscojwho/tab-navigate-sidebar-ipad: - *WIP* tap tab to show/hide sidebar on regular horizontal size class.
# Conflicts: # Mlem.xcodeproj/project.pbxproj # Mlem/Views/Shared/Accounts/Accounts Page.swift # Mlem/Views/Shared/Links/Community Link View.swift # Mlem/Views/Shared/Links/User/UserLinkView.swift # Mlem/Views/Tabs/Feeds/Feed Root.swift # Mlem/Views/Tabs/Feeds/Feed View.swift # Mlem/Views/Tabs/Settings/Components/Views/Appearance/Community/CommunitySettingsView.swift # Mlem/Views/Tabs/Settings/Components/Views/Appearance/User/UserSettingsView.swift # Mlem/Window.swift
boscojwho
requested review from
JakeShirley and
mormaer
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.