fix - allow .admin value on APIPerson to be considered optional
#600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mormaer
requested review from
ShadowJonathan and
EricBAndrews
and removed request for
a team
EricBAndrews
approved these changes
Sep 14, 2023
boscojwho
pushed a commit
to boscojwho/mlem
that referenced
this pull request
Sep 16, 2023
EricBAndrews
pushed a commit
that referenced
this pull request
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- beehaw now returning nowt for this value 😞
Pull Request Information
About this Pull Request
A small change to treat the
.adminvalue as optional as currently the Beehaw instance is no longer returning it. The instance is still stating it is running0.18.4with no changes, however this appears to not be the case. If the value returns on Beehaw we should make this a non-optional value again to match the ever accurate and trustworthy documentation of this API.Screenshots and Videos
No UI changes.