Added extra unit tests in the driver #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
added a commit
that referenced
this pull request
May 2, 2014
Added extra unit tests in the driver
| @@ -7,7 +7,7 @@ | |||
| use Symfony\Component\HttpKernel\Client; | |||
|
|
|||
| /** | |||
| * @group browserkitdriver | |||
| * @group functional | |||
There was a problem hiding this comment.
I saw you did the opposite change for the MinkGoutteDriver. Technically all drivers tests are functional ones, but all Mink tests are unit tests.
There was a problem hiding this comment.
no. I did exactly the same change: https://github.com/Behat/MinkGoutteDriver/blob/master/tests/Behat/Mink/Driver/GoutteDriverTest.php#L8
Having a different group per driver is a left-over from Mink 1.3 when the drivers were in the main repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/Behat/MinkBrowserKitDriver/issues/36