This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Added tests covering the 2 ways to instantiate the driver #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests are failing because https://github.com/Behat/MinkGoutteDriver/pull/39 is not merged yet |
|
This PR closes https://github.com/Behat/MinkGoutteDriver/issues/29 as we reach 100%, which should be high enough |
| /** | ||
| * @group unit | ||
| */ | ||
| class ExtraDriverTest extends \PHPUnit_Framework_TestCase |
There was a problem hiding this comment.
Maybe we should test that too into the MinkBrowserKitDriver too (that returned client is of correct type + it's matching the one we've given in constructor).
There was a problem hiding this comment.
I have some extra tests for MinkBrowserKitDriver locally too (failing for now because they are expecting the changes done in other pending PRs). I will submit them as soon as the other PRs are merged
There was a problem hiding this comment.
stof
added a commit
that referenced
this pull request
May 2, 2014
Added tests covering the 2 ways to instantiate the driver
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the extra unit tests as a separate testcase to ensure we won't hide some test from the common driver testsuite by mistake (it was the case at some point in MinkSeleniumDriver IIRC)