Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ADR list and add ADR for workspace use #8985

Merged
merged 1 commit into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Date: 2024-07-10

## Status

🤔 Proposed
✅ Accepted

## Context

Expand Down
2 changes: 1 addition & 1 deletion architecture-decision-record/0034-use-cloud-map.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# 33. Use of AWS Cloud Map
# 34. Use of AWS Cloud Map

Date: 2024-12-01

Expand Down
20 changes: 20 additions & 0 deletions architecture-decision-record/0035-terraform-workspaces.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# 35. Use of Terraform Workspaces

Date: 2024-12-01

## Status

✅ Accepted

## Context

Terraform [workspaces](https://developer.hashicorp.com/terraform/language/state/workspaces) allow us to use code consistently across environments while maintain separation of state files.

## Decision

We will continue the use of workspaces for separation. Code which uses the `default` workspace will be documented here as an exception.

## Exceptions

* `terraform/modernisation-platform-account`
* `terraform/github`
6 changes: 4 additions & 2 deletions architecture-decision-record/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,10 @@ This is our architecture decision log, made during the design and build of the M
1. ♻ [How we deploy shared Active Directory controllers](0029-how-we-deploy-shared-active-directory-controllers.md)
1. ✅ [Cross environment network access](0030-cross-environment-network-access.md)
1. ✅ [LLMs will be hosted on the Analytical Platform](0031-llms-will-be-hosted-on-the-analytical-platform.md)
1. 🤔 [NCSC PDNS will not be applied at platform level](0032-ncsc-pdns-not-at-platform-level.md)

1. ✅ [NCSC PDNS will not be applied at platform level](0032-ncsc-pdns-not-at-platform-level.md)
1. ❌ [Increase security of sensitive S3 objects (state bucket)](0033-s3-state-bucket-condition-security.md)
1. ❌ [Use of AWS Cloud Map](0034-use-cloud-map.md)
1. ✅ [Use of Terraform Workspaces](0035-terraform-workspaces.md)

## Statuses

Expand Down
Loading