Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ADR list and add ADR for workspace use #8985

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Jan 16, 2025

A reference to the issue / Description of it

#8960

How does this PR fix the problem?

It doesn't, but it does document the decision

How has this been tested?

N/A

Deployment Plan / Instructions

N/A

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@dms1981 dms1981 requested a review from a team as a code owner January 16, 2025 10:53
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 16, 2025
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@dms1981 dms1981 enabled auto-merge January 16, 2025 11:02
Copy link
Contributor

@Khatraf Khatraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dms1981 dms1981 added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 3483bbf Jan 16, 2025
4 checks passed
@dms1981 dms1981 deleted the docs/adr-for-terraform-workspaces branch January 16, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants