Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5659: Bump ruby 3.4.1 #2190

Merged
merged 2 commits into from
Jan 7, 2025
Merged

AP-5659: Bump ruby 3.4.1 #2190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9abad76
AP-5659: Bump ruby 3.3.6 to 3.4.1
jsugarman Dec 30, 2024
268860d
Chore: Replace deprecated MAINTAINER with LABEL in docker file
jsugarman Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ executors:
TZ: Europe/London
linting-executor:
docker:
- image: cimg/ruby:3.3.6-node
- image: cimg/ruby:3.4.1-node
environment:
RAILS_ENV: test
TZ: "Europe/London"
test-executor:
docker:
- image: cimg/ruby:3.3.6-node
- image: cimg/ruby:3.4.1-node
environment:
RAILS_ENV: test
PGHOST: localhost
Expand All @@ -47,7 +47,7 @@ references:
restore_gems_cache: &restore_gems_cache
restore_cache:
keys:
- laa-hmrc-interface-{{ checksum "Gemfile.lock" }}-v3.3.6
- laa-hmrc-interface-{{ checksum "Gemfile.lock" }}-v3.4.1
install_gems: &install_gems
run:
name: Install ruby gems
Expand All @@ -56,7 +56,7 @@ references:
bundle install --path=vendor/bundle --jobs=4 && bundle clean
save_gems_cache: &save_gems_cache
save_cache:
key: laa-hmrc-interface-{{ checksum "Gemfile.lock" }}-v3.3.6
key: laa-hmrc-interface-{{ checksum "Gemfile.lock" }}-v3.4.1
paths:
- vendor/bundle
install_packages_for_testing: &install_packages_for_testing
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ruby-3.3.6
ruby-3.4.1
8 changes: 6 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
FROM ruby:3.3.6-alpine3.21
FROM ruby:3.4.1-alpine3.21

MAINTAINER Apply for legal aid team
LABEL org.opencontainers.image.vendor="Ministry of Justice" \
org.opencontainers.image.authors="Apply for civil legal aid team ([email protected])" \
org.opencontainers.image.title="LAA HMRC Interface Service API" \
org.opencontainers.image.description="Wrapper API for accessing HRMC API for LAA use cases" \
org.opencontainers.image.url="https://github.com/ministryofjustice/laa-hmrc-interface-service-api"

ENV RAILS_ENV production

Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ DEPENDENCIES
webmock

RUBY VERSION
ruby 3.3.6p108
ruby 3.4.1p0

BUNDLED WITH
2.6.2
Loading