Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5659: Bump ruby 3.4.1 #2190

Merged
merged 2 commits into from
Jan 7, 2025
Merged

AP-5659: Bump ruby 3.4.1 #2190

merged 2 commits into from
Jan 7, 2025

Conversation

jsugarman
Copy link
Contributor

@jsugarman jsugarman commented Dec 30, 2024

What

Bump ruby 3.3.6 to 3.4.1

Link to story

Also, replace deprecated MAINTAINER with LABEL in docker file**

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake.
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.
  • You should have run NOCOVERAGE=true rake rswag to ensure the swagger docs are up-to-date

@jsugarman
Copy link
Contributor Author

Will have to wait for CircleCI cimg/ruby:3.4.1-node image to become available

@jsugarman jsugarman added the blocked needs other changes label Dec 30, 2024
@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch 2 times, most recently from 9de4d09 to fa17898 Compare January 3, 2025 12:00
@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch from fa17898 to 869f070 Compare January 6, 2025 11:59
@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch from 869f070 to 268860d Compare January 7, 2025 13:02
@jsugarman jsugarman added ready for review and removed blocked needs other changes labels Jan 7, 2025
Copy link

sonarqubecloud bot commented Jan 7, 2025

@jsugarman jsugarman marked this pull request as ready for review January 7, 2025 13:08
@jsugarman jsugarman requested a review from a team as a code owner January 7, 2025 13:08
@jsugarman jsugarman merged commit e49e2f3 into main Jan 7, 2025
10 checks passed
@jsugarman jsugarman deleted the ap-5659/bump-ruby-3.4.1 branch January 7, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants