-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP-5143: Remove geckoboard updates #7370
AP-5143: Remove geckoboard updates #7370
Conversation
0009c55
to
cd8a324
Compare
Remove the applicant_emailed geckoboard notification
0082131
to
306e3a4
Compare
ed8d2b4
to
ea217fa
Compare
ea217fa
to
211481b
Compare
With the removal of this hook an inadvertent side effect has been removed ``` after_create do ActiveSupport::Notifications.instrument "dashboard.application_created", id:, state: end ```` The calling of the `state` method in this code means it actually calls `state_machine_proxy` method, which creates a `state_machine` relation on the application if it does not have one. Its removal therefore opens up issues both in tests andpossibly functioning of the app. By replacing it with an explcit call to `state_machine_proxy` aliased as `find_or_create_state_machine` we avoid the issue.
…e-machine-after-create AP-5143: initiate state machine after create
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 🧹 🏆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On behalf of Colin and from my own POV, despite having worked on it!
What
Remove Geckoboard
With Geckoboard being decommissioned, we no longer need to send data to our dashboard(s), therefore, we should remove all related code from the project.
Also, for reference see Export stats to Geckoboard and Make dashboard widgets event-driven
First commit - Starting to build a single PR that removes dashboard notifications, one by one.
Note
This is to provide an example of the depth we need to look for these updates
If you want to try deleting another event, feel free to follow the guidance of the first PR as some of the steps are not as obvious as you'd expect!
Checklist
Before you ask people to review this PR:
bundle exec rake
git rebase main
.