Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5143: Remove geckoboard updates #7370

Merged

Conversation

colinbruce
Copy link
Contributor

@colinbruce colinbruce commented Oct 25, 2024

What

Remove Geckoboard

With Geckoboard being decommissioned, we no longer need to send data to our dashboard(s), therefore, we should remove all related code from the project.

Also, for reference see Export stats to Geckoboard and Make dashboard widgets event-driven

First commit - Starting to build a single PR that removes dashboard notifications, one by one.

Note

This is to provide an example of the depth we need to look for these updates

If you want to try deleting another event, feel free to follow the guidance of the first PR as some of the steps are not as obvious as you'd expect!

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@naseberry naseberry force-pushed the ap-5143/remove-applicant_emailed-geckoboard-notification branch from 0009c55 to cd8a324 Compare November 11, 2024 08:40
@skdejong skdejong force-pushed the ap-5143/remove-applicant_emailed-geckoboard-notification branch from 0082131 to 306e3a4 Compare November 13, 2024 15:36
@skdejong skdejong force-pushed the ap-5143/remove-applicant_emailed-geckoboard-notification branch 3 times, most recently from ed8d2b4 to ea217fa Compare November 14, 2024 15:57
@skdejong skdejong force-pushed the ap-5143/remove-applicant_emailed-geckoboard-notification branch from ea217fa to 211481b Compare November 14, 2024 15:59
With the removal of this hook an inadvertent side effect has been
removed
```
  after_create do
    ActiveSupport::Notifications.instrument "dashboard.application_created", id:, state:
  end
````

The calling of the `state` method in this code means it actually calls
`state_machine_proxy` method, which creates a `state_machine` relation
on the application if it does not have one. Its removal therefore opens
up issues both in tests andpossibly functioning of the app.

By replacing it with an explcit call to `state_machine_proxy` aliased
as `find_or_create_state_machine` we avoid the issue.
…e-machine-after-create

AP-5143: initiate state machine after create
@skdejong skdejong added the ready for review Please review label Nov 15, 2024
Copy link
Contributor Author

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 🧹 🏆

@jsugarman jsugarman self-requested a review November 15, 2024 11:34
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On behalf of Colin and from my own POV, despite having worked on it!

@skdejong skdejong added UAT approved Approved by code reviewers Ready to merge Has passed UAT testing and can be merged into master and removed ready for review Please review UAT labels Nov 15, 2024
@skdejong skdejong marked this pull request as ready for review November 18, 2024 14:56
@skdejong skdejong requested a review from a team as a code owner November 18, 2024 14:56
@skdejong skdejong merged commit b9b719f into main Nov 18, 2024
14 checks passed
@skdejong skdejong deleted the ap-5143/remove-applicant_emailed-geckoboard-notification branch November 18, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers Ready to merge Has passed UAT testing and can be merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants