AP-5143: Remove geckoboard updates

Remove the applicant_emailed geckoboard notification
ministryofjustice · Oct 25, 2024 · cd8a324 · cd8a324
1 parent 653c38e
commit cd8a324
Show file tree

Hide file tree

Showing 9 changed files with 1 addition and 224 deletions.
diff --git a/app/jobs/dashboard/applicant_email_job.rb b/app/jobs/dashboard/applicant_email_job.rb
diff --git a/app/models/dashboard/single_object/applicant_email.rb b/app/models/dashboard/single_object/applicant_email.rb
diff --git a/app/services/citizen_email_service.rb b/app/services/citizen_email_service.rb
@@ -13,7 +13,6 @@ def send_email
       addressee: applicant.email_address,
       arguments: mailer_args,
     )
-    notify_dashboard
   end
 
 private
@@ -22,13 +21,6 @@ def send_email
 
   delegate :applicant, :provider, to: :legal_aid_application, allow_nil: true
 
-  def notify_dashboard
-    ActiveSupport::Notifications.instrument(
-      "dashboard.applicant_emailed",
-      legal_aid_application_id: legal_aid_application.id,
-    )
-  end
-
   def mailer_args
     [
       legal_aid_application.application_ref,

diff --git a/app/services/dashboard_event_handler.rb b/app/services/dashboard_event_handler.rb
@@ -39,8 +39,7 @@ def valid_events
        firm_created
        feedback_created
        application_submitted
-       declined_open_banking
-       applicant_emailed]
+       declined_open_banking]
   end
 
   def application_created
@@ -71,8 +70,4 @@ def feedback_created
   def application_submitted
     Dashboard::UpdaterJob.perform_later("Applications")
   end
-
-  def applicant_emailed
-    Dashboard::ApplicantEmailJob.perform_later(LegalAidApplication.find(payload[:legal_aid_application_id]))
-  end
 end
diff --git a/config/application.rb b/config/application.rb
@@ -123,19 +123,16 @@ class Application < Rails::Application
     config.x.suspended_geckoboard_updater_jobs = {
       development: %w[
         Dashboard::FeedbackItemJob
-        Dashboard::ApplicantEmailJob
         Dashboard::ProviderDataJob
         Dashboard::UpdaterJob
       ],
       test: %w[
         Dashboard::FeedbackItemJob
-        Dashboard::ApplicantEmailJob
         Dashboard::ProviderDataJob
         Dashboard::UpdaterJob
       ],
       uat: %w[
         Dashboard::FeedbackItemJob
-        Dashboard::ApplicantEmailJob
         Dashboard::ProviderDataJob
         Dashboard::UpdaterJob
       ],

diff --git a/spec/jobs/dashboard/applicant_email_job_spec.rb b/spec/jobs/dashboard/applicant_email_job_spec.rb
diff --git a/spec/models/dashboard/single_object/applicant_email_spec.rb b/spec/models/dashboard/single_object/applicant_email_spec.rb
diff --git a/spec/services/citizen_email_service_spec.rb b/spec/services/citizen_email_service_spec.rb
@@ -45,16 +45,5 @@
 
       send_email
     end
-
-    it "notifies the dashboard" do
-      allow(ActiveSupport::Notifications).to receive(:instrument)
-
-      send_email
-
-      expect(ActiveSupport::Notifications).to have_received(:instrument).with(
-        "dashboard.applicant_emailed",
-        legal_aid_application_id: legal_aid_application.id,
-      )
-    end
   end
 end
diff --git a/spec/services/dashboard_event_handler_spec.rb b/spec/services/dashboard_event_handler_spec.rb
@@ -149,13 +149,4 @@
       legal_aid_application.merits_complete!
     end
   end
-
-  context "when an applicant is emailed" do
-    let(:legal_aid_application) { create(:legal_aid_application, :with_applicant) }
-
-    it "fires the applicant_email job" do
-      expect(Dashboard::ApplicantEmailJob).to receive(:perform_later).at_least(:once)
-      CitizenEmailService.new(legal_aid_application).send_email
-    end
-  end
 end