Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated models and request builders #512

Closed
wants to merge 2 commits into from

Conversation

andrueastman
Copy link
Member

This pull request was automatically created by Azure Pipelines. Important Check for unexpected deletions or changes in this PR.

@baywet
Copy link
Member

baywet commented Feb 28, 2024

@andrueastman @irvinesunday I think we've had an undesired change in the metadata processing this week:
The select/expand/orderby query parameters are now enums. This is not only breaking, but it also impacts the size of the SDKs, and is incomplete (with expand/select one can also do nested selects/expands and those are not reflected)

see this:

export const GetExpandQueryParameterTypeObject = {
    Asterisk: "*",
    SharedCookies: "sharedCookies",
    Sites: "sites",
} as const;
export const GetOrderbyQueryParameterTypeObject = {
    Id: "id",
    IdDesc: "id desc",
    Description: "description",
    DescriptionDesc: "description desc",
    DisplayName: "displayName",
    DisplayNameDesc: "displayName desc",
    LastModifiedBy: "lastModifiedBy",
    LastModifiedByDesc: "lastModifiedBy desc",
    LastModifiedDateTime: "lastModifiedDateTime",
    LastModifiedDateTimeDesc: "lastModifiedDateTime desc",
    PublishedBy: "publishedBy",
    PublishedByDesc: "publishedBy desc",
    PublishedDateTime: "publishedDateTime",
    PublishedDateTimeDesc: "publishedDateTime desc",
    Revision: "revision",
    RevisionDesc: "revision desc",
    Status: "status",
};

in b/packages/msgraph-sdk-admin/admin/edge/internetExplorerMode/siteLists/index.ts

@andrueastman
Copy link
Member Author

@andrueastman @irvinesunday I think we've had an undesired change in the metadata processing this week: The select/expand/orderby query parameters are now enums. This is not only breaking, but it also impacts the size of the SDKs, and is incomplete (with expand/select one can also do nested selects/expands and those are not reflected)

see this:

export const GetExpandQueryParameterTypeObject = {
    Asterisk: "*",
    SharedCookies: "sharedCookies",
    Sites: "sites",
} as const;
export const GetOrderbyQueryParameterTypeObject = {
    Id: "id",
    IdDesc: "id desc",
    Description: "description",
    DescriptionDesc: "description desc",
    DisplayName: "displayName",
    DisplayNameDesc: "displayName desc",
    LastModifiedBy: "lastModifiedBy",
    LastModifiedByDesc: "lastModifiedBy desc",
    LastModifiedDateTime: "lastModifiedDateTime",
    LastModifiedDateTimeDesc: "lastModifiedDateTime desc",
    PublishedBy: "publishedBy",
    PublishedByDesc: "publishedBy desc",
    PublishedDateTime: "publishedDateTime",
    PublishedDateTimeDesc: "publishedDateTime desc",
    Revision: "revision",
    RevisionDesc: "revision desc",
    Status: "status",
};

in b/packages/msgraph-sdk-admin/admin/edge/internetExplorerMode/siteLists/index.ts

I don't think we've made any updates to the conversion lib between Tuesday and now as well as Metadata updates.
Currently looking into this. This is most probably caused by a change in Kiota.

@baywet
Copy link
Member

baywet commented Feb 29, 2024

closing since we know where the impact is coming from, will queue another generation

@baywet baywet closed this Feb 29, 2024
@baywet baywet deleted the v1.0/pipelinebuild/137498 branch February 29, 2024 13:35
@andrueastman
Copy link
Member Author

I don't think we've made any updates to the conversion lib between Tuesday and now as well as Metadata updates. Currently looking into this. This is most probably caused by a change in Kiota.

I am so sure I posted a follow up message about the root cause here. But it's not here (and I can't find it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants