Revert "Add generation of enum array in query"

[andrueastman]

Reverts #4226

From conversation at microsoftgraph/msgraph-sdk-typescript#512

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[baywet]

Thanks for quickly identifying the root cause. I don't think we should revert that PR, but rather change the conversion behaviour.
Here is what I think it should project vs what it currently projects:

query param name	current type	desired type	note
count	bool	bool
select	array of enum	array of string	nested expand/select would make for a very large enum definition when projecting all the possibilities, and today's projection is lacking a lot
expand	array of enum	array of string	same rationale as select
filter	string	string
orderBy	array of enum	string	I believe you can order by a sub-property in some odata scenarios, and projecting all possibilities would get verbose
top	int	int
skip	int	int
search	string	string
format	string	string

Effectively only the projections of select, orderby and expand need to change.
What do you think?

[baywet]

added some of that context here microsoft/OpenAPI.NET.OData#197

[andrueastman]

The select,expand and orderBy parameters are small set though so the change could be made relatively quickly.
In my head, reverting this PR was going to always be a temporary measure, given that Kiota is technically doing the right thing.

I can close this for now and let this get sorted out at the metadata end.

[baywet]

(please keep the branch for now, I have queued typescript generation)