Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rephrase the menu names for new Java file command #800

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Rephrase the menu names for new Java file command #800

merged 2 commits into from
Nov 24, 2023

Conversation

testforstephen
Copy link
Contributor

image
->
image

image
->
image

image
->
image

@testforstephen testforstephen requested a review from jdneo November 23, 2023 07:26
@jdneo
Copy link
Member

jdneo commented Nov 23, 2023

Please also update the ui test code

vscode-java-dependency/test/ui/command.test.ts

Line 124 in b8e402f

assert.ok(await inputBox.getPlaceHolder() === "Input the class name", `InputBox "Input the class name" should appear`);

jdneo
jdneo approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdneo jdneo added this to the 0.23.3 milestone Nov 24, 2023
@jdneo jdneo added the enhancement New feature or request label Nov 24, 2023
@jdneo jdneo merged commit 69268d9 into main Nov 24, 2023
7 checks passed
@jdneo jdneo deleted the jinbo_newfile branch November 24, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.23.3
Development

Successfully merging this pull request may close these issues.
2 participants
@testforstephen @jdneo