ux: Rephrase the menu names for new Java file command (#800)

microsoft · Nov 24, 2023 · 69268d9 · 69268d9
1 parent b8e402f
commit 69268d9
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 16 deletions.
diff --git a/jdtls.ext/com.microsoft.jdtls.ext.target/com.microsoft.jdtls.ext.tp.target b/jdtls.ext/com.microsoft.jdtls.ext.target/com.microsoft.jdtls.ext.tp.target
@@ -14,11 +14,8 @@
             <unit id="org.eclipse.equinox.sdk.feature.group" version="0.0.0"/>
             <unit id="org.eclipse.jdt.source.feature.group" version="0.0.0"/>
             <unit id="org.eclipse.sdk.feature.group" version="0.0.0"/>
-            <repository location="https://download.eclipse.org/eclipse/updates/4.28/R-4.28-202306050440/"/>
-        </location>
-        <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
             <unit id="org.eclipse.xtext.xbase.lib" version="0.0.0"/>
-            <repository location="https://download.eclipse.org/releases/2023-06/"/>
+            <repository location="https://download.eclipse.org/releases/2023-12/202311171000/"/>
         </location>
         <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
             <unit id="org.eclipse.jdt.ls.core" version="0.0.0"/>

diff --git a/package.nls.json b/package.nls.json
@@ -22,15 +22,15 @@
   "contributes.commands.java.view.package.copyFilePath": "Copy Path",
   "contributes.commands.java.view.package.copyRelativeFilePath": "Copy Relative Path",
   "contributes.commands.java.view.package.new": "New...",
-  "contributes.commands.java.view.package.newJavaClass": "Java Class",
-  "contributes.commands.java.view.package.newPackage": "Package",
-  "contributes.commands.java.view.package.newFile": "File",
+  "contributes.commands.java.view.package.newJavaClass": "Java Class...",
+  "contributes.commands.java.view.package.newPackage": "Package...",
+  "contributes.commands.java.view.package.newFile": "File...",
   "contributes.commands.java.view.package.newFolder": "Folder",
   "contributes.commands.java.view.package.renameFile": "Rename",
   "contributes.commands.java.view.package.moveFileToTrash": "Delete",
   "contributes.commands.java.view.package.deleteFilePermanently": "Delete Permanently",
   "contributes.submenus.javaProject.new": "New",
-  "contributes.commands.java.view.menus.file.newJavaClass": "New Java Class",
+  "contributes.commands.java.view.menus.file.newJavaClass": "New Java File",
   "configuration.java.dependency.showMembers": "Show the members in the explorer",
   "configuration.java.dependency.syncWithFolderExplorer": "Link Java Projects Explorer with the active editor",
   "configuration.java.dependency.autoRefresh": "Synchronize Java Projects explorer with changes",

diff --git a/package.nls.zh-cn.json b/package.nls.zh-cn.json
@@ -22,9 +22,9 @@
   "contributes.commands.java.view.package.copyFilePath": "复制路径",
   "contributes.commands.java.view.package.copyRelativeFilePath": "复制相对路径",
   "contributes.commands.java.view.package.new": "创建...",
-  "contributes.commands.java.view.package.newJavaClass": "Java 类",
-  "contributes.commands.java.view.package.newPackage": "包",
-  "contributes.commands.java.view.package.newFile": "文件",
+  "contributes.commands.java.view.package.newJavaClass": "Java 类...",
+  "contributes.commands.java.view.package.newPackage": "包...",
+  "contributes.commands.java.view.package.newFile": "文件...",
   "contributes.commands.java.view.package.newFolder": "文件夹",
   "contributes.commands.java.view.package.renameFile": "重命名",
   "contributes.commands.java.view.package.moveFileToTrash": "删除",

diff --git a/package.nls.zh-tw.json b/package.nls.zh-tw.json
@@ -20,9 +20,9 @@
   "contributes.commands.java.view.package.copyFilePath": "複製路徑",
   "contributes.commands.java.view.package.copyRelativeFilePath": "複製相對路徑",
   "contributes.commands.java.view.package.new": "建立...",
-  "contributes.commands.java.view.package.newJavaClass": "Java 類別",
-  "contributes.commands.java.view.package.newPackage": "套件",
-  "contributes.commands.java.view.package.newFile": "檔案",
+  "contributes.commands.java.view.package.newJavaClass": "Java 類別...",
+  "contributes.commands.java.view.package.newPackage": "套件...",
+  "contributes.commands.java.view.package.newFile": "檔案...",
   "contributes.commands.java.view.package.newFolder": "資料夾",
   "contributes.commands.java.view.package.renameFile": "重新命名",
   "contributes.commands.java.view.package.moveFileToTrash": "刪除",

diff --git a/src/explorerCommands/new.ts b/src/explorerCommands/new.ts
@@ -82,7 +82,7 @@ export async function newJavaClass(node?: DataNode): Promise<void> {
     }
 
     const className: string | undefined = await window.showInputBox({
-        placeHolder: "Input the class name",
+        placeHolder: "Enter the Java file name for class/interface/enum/record/@interface",
         ignoreFocusOut: true,
         validateInput: async (value: string): Promise<string> => {
             const checkMessage: string = checkJavaQualifiedName(value);

diff --git a/test/ui/command.test.ts b/test/ui/command.test.ts
@@ -121,7 +121,7 @@ describe("Command Tests", function() {
         assert.ok(quickPick, `Quickpick item "src/main/java" should be found`);
         await quickPick!.click();
         inputBox = await InputBox.create();
-        assert.ok(await inputBox.getPlaceHolder() === "Input the class name", `InputBox "Input the class name" should appear`);
+        assert.ok(await inputBox.getPlaceHolder() === "Enter the Java file name for class/interface/enum/record/@interface", `InputBox "Enter the Java file name" should appear`);
         await inputBox.setText("App2");
         await inputBox.confirm();
         await sleep(1000);