Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternate implementation to deal with extraneous RST code in C++ generated lepton files #44

Merged
merged 6 commits into from
Sep 8, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added images/trailingrst_missing_in_jpg.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/trailingrst_missing_in_jpg.lep
Binary file not shown.
20 changes: 19 additions & 1 deletion src/structs/lepton_format.rs
Original file line number Diff line number Diff line change
Expand Up @@ -786,6 +786,10 @@ impl LeptonHeader {
reader,
last_data_position,
writer,
self.plain_text_size as u64
- self.garbage_data.len() as u64
- self.raw_jpeg_header_read_index as u64
- SOI.len() as u64,
num_threads,
enabled_features,
)
Expand Down Expand Up @@ -899,6 +903,7 @@ impl LeptonHeader {
reader: &mut R,
last_data_position: u64,
writer: &mut W,
size_limit: u64,
num_threads: usize,
enabled_features: &EnabledFeatures,
) -> Result<Metrics> {
Expand Down Expand Up @@ -949,23 +954,36 @@ impl LeptonHeader {
},
)?;

let mut amount_written: u64 = 0;

// write all the buffers that we collected
for r in results {
amount_written += r.len() as u64;
writer.write_all(&r[..]).context(here!())?;
}

// Injection of restart codes for RST errors supports JPEGs with trailing RSTs.
// Run this logic even if early_eof_encountered to be compatible with C++ version.
//
// This logic is no longer needed for Rust generated Lepton files, since we just use the garbage
// data to store any extra RST codes or whatever else might be at the end of the file.
if self.rst_err.len() > 0 {
let cumulative_reset_markers = if self.jpeg_header.rsti != 0 {
((self.jpeg_header.mcuh * self.jpeg_header.mcuv) - 1) / self.jpeg_header.rsti
} else {
0
} as u8;
for i in 0..self.rst_err[0] as u8 {
// the C++ version will strangely sometimes ask for extra rst codes even if we are at the end of the file and shouldn't
// be emitting anything more, so if we are over or at the size limit then don't emit the RST code
if amount_written >= size_limit {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not it be more correct "amount_written + 2 > size_limit"?

break;
}

let rst = (jpeg_code::RST0 + ((cumulative_reset_markers + i) & 7)) as u8;
writer.write_u8(0xFF)?;
writer.write_u8(rst)?;
amount_written += 2;
}
}

Expand Down Expand Up @@ -1077,7 +1095,7 @@ impl LeptonHeader {
let mut max_last_segment_size = i32::try_from(self.plain_text_size)?
- i32::try_from(self.garbage_data.len())?
- i32::try_from(self.raw_jpeg_header_read_index)?
- 2;
- SOI.len() as i32;

// subtract the segment sizes of all the previous segments (except for the last)
for i in 0..num_threads - 1 {
Expand Down