alternate implementation to deal with extraneous RST code in C++ generated lepton files #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrovman
reviewed
Sep 7, 2023
src/structs/lepton_format.rs
Outdated
| if self.rst_err.len() > 0 { | ||
| let cumulative_reset_markers = if self.jpeg_header.rsti != 0 { | ||
| ((self.jpeg_header.mcuh * self.jpeg_header.mcuv) - 1) / self.jpeg_header.rsti | ||
| } else { | ||
| 0 | ||
| } as u8; | ||
| for i in 0..self.rst_err[0] as u8 { | ||
| // the C++ version will strangely sometimes ask for extra rst codes even if we are at the end of the file and shouldn't | ||
| // be emitting anything more, so if we are over or at the size limit then don't emit the RST code | ||
| if amount_written >= size_limit { |
There was a problem hiding this comment.
Would not it be more correct "amount_written + 2 > size_limit"?
gbrovman
requested changes
Sep 7, 2023
gbrovman
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is slightly less intrusive way to support this weird corner case. Unfortunately the garbage RST code stuff is not very robust in the C++ version. For the Rust version I just encoded everything using the garbage data which is much more robust.