Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Generation to handle parameter of type 'string' but different format #4679

Merged
merged 4 commits into from
May 21, 2024
Merged

CLI Generation to handle parameter of type 'string' but different format #4679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91d24a0
refs #4615 Use GetPrimitiveType() to get the type of GetQueryParamete…
rohitkrsoni May 18, 2024
17b08be
Merge branch 'main' into feature/4615/rohitkrsoni
rohitkrsoni May 20, 2024
366306a
#4615 update Change Log
rohitkrsoni May 21, 2024
df70dbc
Merge branch 'main' into feature/4615/rohitkrsoni
rohitkrsoni May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed a bug where the hash alias in typescript wasn't being generated uniformly for similar interfaces [microsoftgraph/msgraph-beta-sdk-typescript#84](https://github.com/microsoftgraph/msgraph-beta-sdk-typescript/issues/84)
- Fixes a bug where name collisions would occur in the Typescript refiner if model name also exists with the `Interface` suffix [#4382](https://github.com/microsoft/kiota/issues/4382)
- Fixes a bug where paths without operationIds would not be included in the generated plugins and ensured operationIds are cleaned up [#4642](https://github.com/microsoft/kiota/issues/4642)
- Fixes a bug where CLI Generation does not handle path parameters of type "string" and format "date", "date-time", "time", etc. [#4615](https://github.com/microsoft/kiota/issues/4615)

## [1.14.0] - 2024-05-02

Expand Down
2 changes: 1 addition & 1 deletion src/Kiota.Builder/KiotaBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2403,7 +2403,7 @@ private static CodeType GetDefaultQueryParameterType()
};
}
private static CodeType GetQueryParameterType(OpenApiSchema schema) =>
new()
GetPrimitiveType(schema) ?? new()
calebkiage marked this conversation as resolved.
Show resolved Hide resolved
{
IsExternal = true,
Name = schema.Items?.Type ?? schema.Type,
Expand Down
Loading