CLI Generation to handle parameter of type 'string' but different format

[rohitkrsoni]

fixes #4615

CLI Generator is unable to handle parameters such as DateTime, Date, etc. More precisely, the parameters having type="string" and format="datetime", "date" etc.

Screenshots:

Tests:

Kiota Update:

Build of Sample project:

Change in the builder Class:

[rohitkrsoni]

Hi @baywet, are there any further changes required for this PR?

[andrueastman]

@rohitkrsoni Any chance you could add a changelog entry to the Changelog file at the repository root?

[rohitkrsoni]

@rohitkrsoni Any chance you could add a changelog entry to the Changelog file at the repository root?

Done, thanks :)

[baywet]

@rohitkrsoni @andrueastman there seems to be a regression with this one see this smoke build (only microsoft people will see that)

Has about 16k errors like this one : error CS0029: Cannot implicitly convert type 'string' to 'string[]'

This seems to be caused by the fact that the option now is Option<string[]> but the parameter for the method is string no array.
I'm guessing we should expand the fix to include array information for the parameter type. But I'd like more context from @calebkiage here before we make any changes.

[calebkiage]

Ah, I missed the fact that GetPrimitiveTypeName does not handle collection information. We would need to add the collection type information from the schema.

Something like:

    private static CodeType GetQueryParameterType(OpenApiSchema schema)
    {
        var paramType = GetPrimitiveType(schema) ?? new()
        {
            IsExternal = true,
            Name = schema.Items?.Type ?? schema.Type,
        };

        paramType.CollectionKind = schema.IsArray() ? CodeTypeBase.CodeTypeCollectionKind.Array : default,
        return paramType;
    }

[rohitkrsoni]

Hi @baywet, can I get the sample description file so that I can reproduce the issue on my local.

I tried to reproduce the issue by adding a parameter mentioned below.

      - name: testStringArrayParameter
        in: query
        description: 'Usage: newParameter=@newParameter'
        schema:
          type: array
          items:
            type: string

I didn't get any error but got this in Query Parameter properties:

And the option created is:

var testStringArrayParameterOption = new Option<string>("--test-string-array-parameter", description: "Usage: newParameter=@newParameter") {
};
testStringArrayParameterOption.IsRequired = false;
command.AddOption(testStringArrayParameterOption);

Is this behavior expected?

[baywet]

Thanks for the additional context @calebkiage
@rohitkrsoni yes I believe this is the scenario I'm referring to. When the option value gets assigned to the query parameter, the types don't match anymore. Would you mind following up with an additional pull request please?

[rohitkrsoni]

@baywet sure leave that on me!

[rohitkrsoni]

To fix this:
Issue: #4707
PR: #4708