-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Generation] Untyped node support #4095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2024
This was referenced Mar 4, 2024
andrueastman
changed the title
[WIP] Untyped node support
[Generation] Untyped node support
Mar 4, 2024
baywet
previously approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! We'll need to update the changelog once libraries are published but nothing to add besides that.
baywet
requested changes
Mar 20, 2024
baywet
previously approved these changes
Mar 20, 2024
Quality Gate passedIssues Measures |
baywet
approved these changes
Mar 21, 2024
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
It adds generation support for deserialization of properties that have an unknown type("any") in the generation of C#, Go, Typescript and Java by introduction of the generation of the
UntypedNode
type in such scenarios.In summary changes include
UntypedNode
type in Go,C#,Java and TS while callingRemoveUntypedNodePropertyValues
to prevent generation in other langs.End to end tests performed with the "apisguru::apis.guru" api can be validated/tested with the samples here that pull these changes as submodules.
C# sample client code - https://github.com/andrueastman/UntypedNodeSamples/blob/5a7ab13b044e1331583cce9d0aee16c1429afd3e/DotnetUntypedNodeSample/Program.cs#L16
Java sample client code - https://github.com/andrueastman/UntypedNodeSamples/blob/5a7ab13b044e1331583cce9d0aee16c1429afd3e/javaclient/app/src/main/java/javaclient/app/App.java#L17
Go sample client code - https://github.com/andrueastman/UntypedNodeSamples/blob/5a7ab13b044e1331583cce9d0aee16c1429afd3e/goclient/app.go#L21
TS sample client code - https://github.com/andrueastman/UntypedNodeSamples/blob/5a7ab13b044e1331583cce9d0aee16c1429afd3e/TSclient/index.ts#L20
TODO