-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeScript] Untyped Nodes #1084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverted linting changes.
andrueastman
temporarily deployed
to
build_test
February 27, 2024 06:35 — with
GitHub Actions
Inactive
andrueastman
temporarily deployed
to
build_test
February 27, 2024 06:35 — with
GitHub Actions
Inactive
andrueastman
temporarily deployed
to
build_test
February 28, 2024 09:35 — with
GitHub Actions
Inactive
andrueastman
temporarily deployed
to
build_test
February 28, 2024 09:35 — with
GitHub Actions
Inactive
andrueastman
requested review from
baywet,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
gavinbarron and
koros
as code owners
March 4, 2024 18:36
koros
previously approved these changes
Mar 7, 2024
baywet
requested changes
Mar 8, 2024
baywet
requested changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Much better, I believe we still have a few things to finish up
baywet
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to microsoft/kiota#2319
It adds a number of types that implement the Parsable interface to enable the representation of types that are unknown at generation time to unblock the serialization and deserialization of properties of unknown types.
It also adds functionality to the serialization library of Json to be able to serialize and deserialize the types as well as tests for the scenarios.
Generation of these types is unblocked in microsoft/kiota#4095