Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript] Untyped Nodes #1084

Merged
merged 14 commits into from
Mar 20, 2024
Merged

[TypeScript] Untyped Nodes #1084

merged 14 commits into from
Mar 20, 2024

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Feb 27, 2024

This PR is related to microsoft/kiota#2319

It adds a number of types that implement the Parsable interface to enable the representation of types that are unknown at generation time to unblock the serialization and deserialization of properties of unknown types.

It also adds functionality to the serialization library of Json to be able to serialize and deserialize the types as well as tests for the scenarios.

Generation of these types is unblocked in microsoft/kiota#4095

@andrueastman andrueastman changed the title [WIP] Untyped Nodes Untyped Nodes Mar 4, 2024
@andrueastman andrueastman changed the title Untyped Nodes [TypeScript] Untyped Nodes Mar 4, 2024
@andrueastman andrueastman marked this pull request as ready for review March 4, 2024 18:36
koros
koros previously approved these changes Mar 7, 2024
packages/abstractions/package.json Outdated Show resolved Hide resolved
packages/abstractions/src/serialization/untypedArray.ts Outdated Show resolved Hide resolved
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Much better, I believe we still have a few things to finish up

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@andrueastman andrueastman merged commit 5ce4f29 into main Mar 20, 2024
6 checks passed
@andrueastman andrueastman deleted the andrueastman/untypedNodes branch March 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants