Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename composed type wrapper when another class with similar name exists in namespace #3420

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Rename composed type wrapper when another class with similar name exists in namespace #3420

merged 4 commits into from
Oct 5, 2023

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Oct 3, 2023

closes #2964

@Ndiritu Ndiritu added this to the Kiota v1.7 milestone Oct 3, 2023
@Ndiritu Ndiritu self-assigned this Oct 3, 2023
@Ndiritu Ndiritu requested a review from a team as a code owner October 3, 2023 20:36
@Ndiritu Ndiritu force-pushed the fix/composed-wrapper-name branch from 3a0073c to 0f638d2 Compare October 3, 2023 20:41
@Ndiritu Ndiritu marked this pull request as draft October 3, 2023 20:57
@Ndiritu Ndiritu changed the title Rename composed type wrapper when class exists in namespace Rename composed type wrapper when another class with similar name exists in namespace Oct 4, 2023
@Ndiritu Ndiritu force-pushed the fix/composed-wrapper-name branch from 07b5c0c to a492afd Compare October 4, 2023 08:18
@Ndiritu Ndiritu marked this pull request as ready for review October 4, 2023 08:18
andrueastman
andrueastman previously approved these changes Oct 5, 2023
View reviewed changes
src/Kiota.Builder/Refiners/CommonLanguageRefiner.cs Show resolved Hide resolved
src/Kiota.Builder/Refiners/CommonLanguageRefiner.cs Outdated Show resolved Hide resolved
@Ndiritu Ndiritu force-pushed the fix/composed-wrapper-name branch from bd35919 to f39f2e5 Compare October 5, 2023 12:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Ndiritu Ndiritu requested review from baywet and andrueastman October 5, 2023 12:42
@baywet baywet merged commit d17bab2 into main Oct 5, 2023
173 checks passed
@baywet baywet deleted the fix/composed-wrapper-name branch October 5, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman andrueastman approved these changes

Assignees

@Ndiritu Ndiritu

Labels
None yet
Projects
None yet
Milestone
Kiota v1.7
3 participants
@Ndiritu @andrueastman @baywet