Apply code review suggestion

microsoft · Oct 5, 2023 · f39f2e5 · f39f2e5
1 parent 87759f0
commit f39f2e5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/Kiota.Builder/Refiners/CommonLanguageRefiner.cs b/src/Kiota.Builder/Refiners/CommonLanguageRefiner.cs
@@ -479,8 +479,7 @@ private static CodeTypeBase ConvertComposedTypeToWrapper(CodeClass codeClass, Co
         if (!supportsInnerClasses)
         {
             var @namespace = codeClass.GetImmediateParentOfType<CodeNamespace>();
-            var existingClass = @namespace.FindChildByName<CodeClass>(codeComposedType.Name, false);
-            if (existingClass != null && existingClass.OriginalComposedType == null)
+            if (@namespace.FindChildByName<CodeClass>(codeComposedType.Name, false) is CodeClass { OriginalComposedType: null })
                 codeComposedType.Name = $"{codeComposedType.Name}Wrapper";
             newClass = @namespace.AddClass(new CodeClass
             {

diff --git a/tests/Kiota.Builder.Tests/Refiners/PhpLanguageRefinerTests.cs b/tests/Kiota.Builder.Tests/Refiners/PhpLanguageRefinerTests.cs
@@ -258,7 +258,6 @@ public async Task RenamesComposedTypeWrapperWhenSimilarClassExistsInNamespace()
             Name = "property",
             Type = composedType
         });
-
         await ILanguageRefiner.Refine(new GenerationConfiguration { Language = GenerationLanguage.PHP }, root);
         Assert.NotNull(root.FindChildByName<CodeClass>("UnionWrapper", false));
     }
@@ -289,5 +288,4 @@ public async Task DoesNotCreateDuplicateComposedTypeWrapperIfOneAlreadyExists()
         Assert.True(root.FindChildByName<CodeClass>("Union", false) is CodeClass unionTypeWrapper && unionTypeWrapper.OriginalComposedType != null);
         Assert.True(root.FindChildByName<CodeClass>("UnionWrapper", false) is null);
     }
-
 }