Refactor filtering to improve performance #10167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dstepanov
commented
Nov 28, 2023
dstepanov
commented
- Filter runner refactored to enable imperative methods invocation in a loop without multiple lambdas
- Added more unwrapping flow checks for filters and route execution
- Removed a need to have terminal filters
- Changes modified some of the generics and signatures. Filters should work with non-mutable request/response with wildcard body type
graemerocher
approved these changes
Nov 30, 2023
yawkat
reviewed
Dec 4, 2023
http-client-jdk/src/main/java/io/micronaut/http/client/jdk/AbstractJdkHttpClient.java
Outdated
Show resolved
Hide resolved
| */ | ||
| protected RequestLifecycle(RouteExecutor routeExecutor, HttpRequest<?> request) { | ||
| protected RequestLifecycle(RouteExecutor routeExecutor) { |
There was a problem hiding this comment.
i see it's passed around everywhere now, but what's the point of this change?
There was a problem hiding this comment.
With this change, it's clear how the request is processed, because it can be modified it's better to pass it with the flow and avoid mistakes.
There was a problem hiding this comment.
brings back the param list inflation RequestLifecycle was made to avoid though...
There was a problem hiding this comment.
I feel the code flow is more transparent and more accessible to understand this way.
yawkat
approved these changes
Dec 4, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.