Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestLifecycle refactor breaks servlet, which breaks starter 4.3.x development. #10204

Closed
wetted opened this issue Dec 4, 2023 · 1 comment
Assignees

Comments

@wetted
Copy link
Contributor

wetted commented Dec 4, 2023

Issue description

The Starter 4.3.x branch is broken with respect to FunctionSpec tests in starter-aws-lambda, starter-gcp-function and starter-azure-function.

It's a problem in that Starter 4.3.x points to micronaut-http-server-4.3.0-SNAPSHOT where @dstepanov refactored the ctor on #10167, removing a ctor argument, from RequestLifecycle(RouteExecutor routeExecutor, HttpRequest<?> request) to RequestLifecycle(RouteExecutor routeExecutor).

This is incompatible with the version of micronaut-servlet pointed to by starter 4.3.x. Normally this violates semantic versioning, but it is an @Internal class Nevertheless it breaks the Starter 4.3.x branch because that uses core 4.3.x and servlet is trying to call the removed ctor.

I think we either need to restore the 2-arg method and deprecate it; otherwise, we're blocked on passing CI for Starter 4.3.x for the servlet/core mismatch.

@dstepanov
Copy link
Contributor

Fixed in f875db7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants