Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alchemical model #425

Merged
merged 162 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from 161 commits
Commits
Show all changes
162 commits
Select commit Hold shift + click to select a range
98219fb
Update to latest rascaline (#291)
frostedoyster Jul 11, 2024
d11c9e3
Remove consistency checks (except for tests)
frostedoyster Jul 12, 2024
166d15e
Merge branch 'main' into consistency-checks
frostedoyster Jul 12, 2024
7fc1743
NanoPET
frostedoyster Jul 17, 2024
65c1404
Use `check_consistency` in tests
frostedoyster Jul 17, 2024
98ac770
Implement `selected_atoms`
frostedoyster Jul 18, 2024
2e757fd
Merge branch 'consistency-checks' into nanopet
frostedoyster Jul 18, 2024
2ae3da2
Optimized training, there still seems to be a bug
frostedoyster Jul 18, 2024
836e3fc
Fixed bug
frostedoyster Jul 18, 2024
c0df552
Fix attention correctness
frostedoyster Jul 18, 2024
7931989
Add test for consistent predictions with different padding
frostedoyster Jul 18, 2024
aa7b478
Update defaults
frostedoyster Jul 18, 2024
67ffab6
Merge branch 'main' into nanopet
frostedoyster Jul 18, 2024
7223a95
Last-layer features for nanoPET
frostedoyster Jul 19, 2024
2cc92b8
Fix stuff
frostedoyster Jul 22, 2024
d25a340
More fixes
frostedoyster Jul 22, 2024
4d32bdb
More fixxxes
frostedoyster Jul 22, 2024
606b9e2
Fix restart
frostedoyster Jul 22, 2024
28cd708
Revert
frostedoyster Jul 22, 2024
5539623
Fix bug in message passing
frostedoyster Jul 23, 2024
2269541
Fix bug
frostedoyster Jul 23, 2024
3012917
Merge branch 'main' into nanopet
frostedoyster Jul 25, 2024
df4aba6
Merge branch 'main' into nanopet
frostedoyster Jul 30, 2024
61ca9ce
Normalize residual connections
frostedoyster Jul 31, 2024
98aa9b4
Fix torchscript issue
frostedoyster Jul 31, 2024
72f0bcd
Try to change the position encoder
frostedoyster Aug 1, 2024
1cc2e1d
Remove torch hotfix
frostedoyster Aug 2, 2024
cdb1d3d
Upgrade to `metatensor-torch` 0.5.3
frostedoyster Aug 3, 2024
06f88fc
Merge branch 'metatensor-torch-0.5.3' into nanopet
frostedoyster Aug 3, 2024
293c7a6
Revert some changes to the encoder
frostedoyster Sep 5, 2024
94df82e
Remove random factor
frostedoyster Oct 7, 2024
9eff61f
Merge branch 'main' into nanopet
frostedoyster Oct 14, 2024
2fd9b8d
Speed up a tiny bit
frostedoyster Oct 14, 2024
6c8f1da
Merge branch 'main' into nanopet
Oct 15, 2024
713cfbb
Fair comparison to PET
frostedoyster Oct 15, 2024
33e2c70
Calculate displacements independently + format
frostedoyster Oct 16, 2024
4b8d8c1
Fix pyproject.toml
frostedoyster Oct 16, 2024
3377b2d
Dependencies
frostedoyster Oct 17, 2024
63bcfac
Merge branch 'mae-logging' into nanopet
frostedoyster Oct 17, 2024
f79a36d
Automatic continuation
frostedoyster Oct 17, 2024
3c136bf
Call processing function before new `outputs/` directory is created
frostedoyster Oct 18, 2024
c33bcf2
Make it distributed-proof
frostedoyster Oct 18, 2024
4b2a877
Merge branch 'auto-continue' into nanopet
frostedoyster Oct 18, 2024
129c9b9
Only save checkpoints from the main process
frostedoyster Oct 18, 2024
d88cfcf
Merge branch 'main' into nanopet
frostedoyster Oct 18, 2024
a675bfe
Get rid of nanopet-neighbors
frostedoyster Oct 18, 2024
72a6502
Speed up
frostedoyster Oct 18, 2024
fc33c70
Proper cutoff parameters
frostedoyster Oct 20, 2024
a951638
MLP for geometric embedding
frostedoyster Oct 20, 2024
92d2c80
Merge branch 'nanopet' of https://github.com/lab-cosmo/metatrain into…
frostedoyster Oct 20, 2024
45c2fc7
Fix bug
frostedoyster Oct 20, 2024
b8cd9ba
Add sample `TensorMap` to `TargetInfo`
frostedoyster Oct 26, 2024
60b6b0d
Change `TensorMap`s inside `TargetInfo` to `float64` to avoid seriali…
frostedoyster Oct 28, 2024
4c614f7
Better documentation
frostedoyster Oct 28, 2024
172af0b
Upgrade to `metatensor-torch` 0.6.0
frostedoyster Oct 29, 2024
0f3bfd7
Upgrade `metatensor-learn`
frostedoyster Oct 30, 2024
0e8e2f7
Update strict NL
frostedoyster Oct 30, 2024
d632dc2
Fix PBCs
frostedoyster Oct 30, 2024
b65536a
Draft
frostedoyster Nov 1, 2024
cf62ee7
Upgrade rascaline-torch
frostedoyster Nov 1, 2024
0ebcc9a
Fix `slice` argument name
frostedoyster Nov 2, 2024
f7355dd
Merge branch 'upgrade-metatensor' into targetinfo-tensormap
frostedoyster Nov 2, 2024
906d01a
Merge branch 'targetinfo-tensormap' into generic-readers
frostedoyster Nov 2, 2024
d850528
Merge branch 'adapt-models' into nanopet
frostedoyster Nov 4, 2024
5d6ccdb
FIx a few issues
frostedoyster Nov 4, 2024
f881951
Add dataset information overview to the dev docs
frostedoyster Nov 5, 2024
de9a28e
Fix docs
frostedoyster Nov 5, 2024
4f89649
Merge branch 'main' into targetinfo-tensormap
frostedoyster Nov 5, 2024
a9773f4
Merge branch 'targetinfo-tensormap' into generic-readers
frostedoyster Nov 5, 2024
5cc0806
Fix export issue
frostedoyster Nov 6, 2024
775be90
Small fixes
frostedoyster Nov 7, 2024
940bd3c
Better LR decreases
frostedoyster Nov 7, 2024
00f289e
Merge branch 'main' into generic-readers
frostedoyster Nov 10, 2024
758b9c5
Fix stuff
frostedoyster Nov 10, 2024
6d99827
Fix more stuff
frostedoyster Nov 10, 2024
012f141
Fix even more stuff
frostedoyster Nov 10, 2024
4146954
Revert changes to options file
frostedoyster Nov 10, 2024
e93ac4a
Fix tests
frostedoyster Nov 10, 2024
e86192d
Add warning when learning of `forces`, `stress`, `virial` not as grad…
frostedoyster Nov 10, 2024
a1c2146
Update developer docs
frostedoyster Nov 11, 2024
b8647f2
Add user docs for generic targets
frostedoyster Nov 11, 2024
00434c6
Overall and ASE reader tests
frostedoyster Nov 11, 2024
b743030
Move tests
frostedoyster Nov 11, 2024
b815435
Metatensor reader tests
frostedoyster Nov 11, 2024
21d6098
One more test
frostedoyster Nov 11, 2024
f3843d9
Eliminate useless checks that are already performed by the `DictConfi…
frostedoyster Nov 11, 2024
fd4a858
Test error with ASE and multiple spherical irreps
frostedoyster Nov 11, 2024
fb4a24d
One more test
frostedoyster Nov 11, 2024
239428d
Fix bug
frostedoyster Nov 11, 2024
15093de
Test more errors
frostedoyster Nov 11, 2024
2a52859
Allow SOAP-BPNN to fit Cartesian vectors
frostedoyster Nov 11, 2024
13da2b8
Fix composition test
frostedoyster Nov 12, 2024
078fbd6
Add checks and SOAP-BPNN vector test
frostedoyster Nov 12, 2024
77f275b
Bug fix in schema
frostedoyster Nov 12, 2024
af5c126
Merge branch 'generic-readers' into adapt-models
frostedoyster Nov 12, 2024
0370921
Add vector output training test
frostedoyster Nov 12, 2024
76b941f
Fix regression tests
frostedoyster Nov 12, 2024
13e7769
Check that ZBL gets correct targets
frostedoyster Nov 12, 2024
da544ff
Docs
frostedoyster Nov 12, 2024
0e6c46f
Fix bug
frostedoyster Nov 12, 2024
3ff9370
Fix bug
frostedoyster Nov 12, 2024
737c895
Extract function to add outputs for SOAP-BPNN
frostedoyster Nov 12, 2024
998b7ed
Fix some small issues
frostedoyster Nov 12, 2024
5da6e75
Merge branch 'main' into nanopet
frostedoyster Nov 12, 2024
4e1c38a
Merge branch 'adapt-models' into nanopet
frostedoyster Nov 12, 2024
04159f2
Fix leftover merge issues
frostedoyster Nov 12, 2024
dd23a63
Add tests
frostedoyster Nov 13, 2024
853ccf0
Fix `tests/resources` folder
frostedoyster Nov 13, 2024
a777fcb
Merge branch 'main' into generic-readers
frostedoyster Nov 13, 2024
27e6104
Merge branch 'generic-readers' into adapt-models
frostedoyster Nov 13, 2024
3be99cc
Remove commented torch hack
frostedoyster Nov 13, 2024
89bddcc
Merge branch 'adapt-models' into nanopet
frostedoyster Nov 13, 2024
160124f
Undo spurious changes
frostedoyster Nov 13, 2024
79e8b30
Codeowners, tox, GH workflows
frostedoyster Nov 13, 2024
8712d27
Add correct values for regression tests
frostedoyster Nov 13, 2024
afb9059
Add documentation
frostedoyster Nov 13, 2024
e665c7a
Regression test
frostedoyster Nov 13, 2024
aeff14f
Clean up
frostedoyster Nov 13, 2024
4aa2a1c
Fix restart issue
frostedoyster Nov 13, 2024
5cc35c0
Fix test
frostedoyster Nov 13, 2024
d0be159
Fix accidental deletion of test
frostedoyster Nov 13, 2024
a325942
Apply suggestions from code review
frostedoyster Nov 18, 2024
a69dfa7
Fix assert
frostedoyster Nov 18, 2024
025048d
Infer `quantity` in `get_energy_target_info`
frostedoyster Nov 18, 2024
03c6df3
Allow arbitrary properties with `metatensor` reader
frostedoyster Nov 18, 2024
b6f5cd5
Fix tests
frostedoyster Nov 18, 2024
7b4ae53
Merge branch 'main' into generic-readers
frostedoyster Nov 18, 2024
a5416be
Fix tests
frostedoyster Nov 18, 2024
a5a102c
Update docs/src/advanced-concepts/preparing-generic-targets.rst
frostedoyster Nov 19, 2024
155aac5
Suggestions from review
frostedoyster Nov 19, 2024
6fcc7f4
Remove private functions from docs
frostedoyster Nov 19, 2024
405c2cf
Change metatensor target format to a single `TensorMap`
frostedoyster Nov 19, 2024
0c207fc
Merge branch 'generic-readers' into adapt-models
frostedoyster Nov 20, 2024
e158719
Correctly inherit properties from targets in SOAP-BPNN
frostedoyster Nov 20, 2024
7d3bc7d
Merge branch 'adapt-models' into nanopet
frostedoyster Nov 20, 2024
2a590b0
Correctly inherit properties from targets in SOAP-BPNN
frostedoyster Nov 20, 2024
ab1446a
Fix LLPR test
frostedoyster Nov 20, 2024
a15ae29
Fix regressiont tests
frostedoyster Nov 20, 2024
364bd9b
Fix regression tests
frostedoyster Nov 20, 2024
dff9612
Merge branch 'adapt-models' into nanopet
frostedoyster Nov 20, 2024
7c73db6
Add head types to SOAP-BPNN and nanoPET
frostedoyster Nov 20, 2024
d28583e
Update for features and LLPR module
frostedoyster Nov 20, 2024
8296733
Update old tests
frostedoyster Nov 20, 2024
3a66aa9
Docs and new tests
frostedoyster Nov 20, 2024
f598aab
Merge branch 'main' into adapt-models
frostedoyster Nov 21, 2024
23a99fc
Fix docs
frostedoyster Nov 21, 2024
d35fd1b
Make composition restart-proof (continue, fine-tune, transfer learning)
frostedoyster Nov 21, 2024
7754e6d
Add scale to logger
frostedoyster Nov 21, 2024
59e3363
Turn old warning into error
frostedoyster Nov 21, 2024
e6993e4
Merge branch 'adapt-models' into nanopet
frostedoyster Nov 22, 2024
d4c59b6
Scaler class
frostedoyster Nov 22, 2024
7d2c940
Add to documentation
frostedoyster Nov 22, 2024
d46ca0f
num_properties -> num_subtargets
frostedoyster Nov 22, 2024
b137a4a
Merge branch 'nanopet' into heads-and-utils
frostedoyster Nov 22, 2024
5dbc9ed
Merge branch 'heads-and-utils' into scaler
frostedoyster Nov 22, 2024
40ef3ad
Tests
frostedoyster Nov 22, 2024
09bc09b
Fix distributed
frostedoyster Nov 23, 2024
eb200b5
Merge branch 'heads-and-utils' into scaler
frostedoyster Dec 6, 2024
0d91421
Merge branch 'main' into scaler
frostedoyster Dec 12, 2024
2f8ed7e
Fix stuff
frostedoyster Dec 12, 2024
47b3425
Remove alchemical model
frostedoyster Dec 13, 2024
03d42fd
Merge branch 'main' into remove-alchemical
frostedoyster Dec 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/architecture-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ jobs:
strategy:
matrix:
include:
- architecture-name: alchemical-model
- architecture-name: gap
- architecture-name: soap-bpnn
- architecture-name: pet
Expand Down
1 change: 0 additions & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
# is modified.

**/soap_bpnn @frostedoyster
**/alchemical_model @abmazitov
**/pet @abmazitov
**/gap @DavideTisi
**/nanopet @frostedoyster
3 changes: 0 additions & 3 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ model.
Positions (SOAP).
* - SOAP BPNN
- A Behler-Parrinello neural network with SOAP features
* - Alchemical Model
- A Behler-Parrinello neural network with SOAP features and Alchemical Compression
of the composition space
* - PET
- Point Edge Transformer (PET), interatomic machine learning potential

Expand Down
14 changes: 7 additions & 7 deletions docs/src/advanced-concepts/auxiliary-outputs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ by one or more architectures in the library:
The following table shows the architectures that support each of the
auxiliary outputs:

+--------------------------------------------+-----------+------------------+-----+-----+---------+
| Auxiliary output | SOAP-BPNN | Alchemical Model | PET | GAP | NanoPET |
+--------------------------------------------+-----------+------------------+-----+-----+---------+
| ``mtt::aux::{target}_last_layer_features`` | Yes | No | No | No | Yes |
+--------------------------------------------+-----------+------------------+-----+-----+---------+
| ``features`` | Yes | No | No | No | Yes |
+--------------------------------------------+-----------+------------------+-----+-----+---------+
+--------------------------------------------+-----------+-----+-----+---------+
| Auxiliary output | SOAP-BPNN | PET | GAP | NanoPET |
+--------------------------------------------+-----------+-----+-----+---------+
| ``mtt::aux::{target}_last_layer_features`` | Yes | No | No | Yes |
+--------------------------------------------+-----------+-----+-----+---------+
| ``features`` | Yes | No | No | Yes |
+--------------------------------------------+-----------+-----+-----+---------+

The following tables show the metadata that will be provided for each of the
auxiliary outputs:
Expand Down
5 changes: 0 additions & 5 deletions docs/src/advanced-concepts/fitting-generic-targets.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ capabilities of the architectures in metatrain.
- Yes
- Only with ``o3_lambda=1, o3_sigma=1``
- No
* - Alchemical Model
- Energy, forces, stress/virial
- No
- No
- No
* - GAP
- Energy, forces
- No
Expand Down
141 changes: 0 additions & 141 deletions docs/src/architectures/alchemical-model.rst

This file was deleted.

2 changes: 2 additions & 0 deletions docs/src/architectures/nanopet.rst
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ The hyperparameters for training are
:param scheduler_factor: Factor to reduce the learning rate by
:param log_interval: Interval at which to log training metrics
:param checkpoint_interval: Interval at which to save model checkpoints
:param scale_targets: Whether to scale the targets to have unit standard deviation
across the training set during training.
:param fixed_composition_weights: Weights for fixed atomic contributions to scalar
targets
:param per_structure_targets: Targets to calculate per-structure losses for
Expand Down
2 changes: 2 additions & 0 deletions docs/src/architectures/soap-bpnn.rst
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ The parameters for training are
:param learning_rate: learning rate
:param log_interval: number of epochs that elapse between reporting new training results
:param checkpoint_interval: Interval to save a checkpoint to disk.
:param scale_targets: Whether to scale the targets to have unit standard deviation
across the training set during training.
:param fixed_composition_weights: allows to set fixed isolated atom energies from
outside. These are per target name and per (integer) atom type. For example,
``fixed_composition_weights: {"energy": {1: -396.0, 6: -500.0}, "mtt::U0": {1: 0.0,
Expand Down
7 changes: 7 additions & 0 deletions docs/src/dev-docs/utils/scaler.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Scaler
######

.. automodule:: metatrain.utils.scaler
:members:
:undoc-members:
:show-inheritance:
23 changes: 0 additions & 23 deletions docs/static/refs.bib
Original file line number Diff line number Diff line change
Expand Up @@ -42,29 +42,6 @@ @article{willatt_feature_2018
langid = {english}
}

@article{mazitov_surface_2024,
author={Mazitov, Arslan and Springer, Maximilian A. and Lopanitsyna, Nataliya and Fraux, Guillaume and De, Sandip and Ceriotti, Michele},
title={Surface segregation in high-entropy alloys from alchemical machine learning},
journal={Journal of Physics: Materials},
url={http://iopscience.iop.org/article/10.1088/2515-7639/ad2983},
year={2024},
}

@article{lopanitsyna_modeling_2023,
title = {Modeling high-entropy transition metal alloys with alchemical compression},
author = {Lopanitsyna, Nataliya and Fraux, Guillaume and Springer, Maximilian A. and De, Sandip and Ceriotti, Michele},
journal = {Phys. Rev. Mater.},
volume = {7},
issue = {4},
pages = {045802},
numpages = {15},
year = {2023},
month = {Apr},
publisher = {American Physical Society},
doi = {10.1103/PhysRevMaterials.7.045802},
url = {https://link.aps.org/doi/10.1103/PhysRevMaterials.7.045802}
}

@article{bigi_smooth_2022,
author = {Bigi, Filippo and Huguenin-Dumittan, Kevin K. and Ceriotti, Michele and Manolopoulos, David E.},
title = "{A smooth basis for atomistic machine learning}",
Expand Down
3 changes: 0 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ build-backend = "setuptools.build_meta"
soap-bpnn = [
"rascaline-torch @ git+https://github.com/luthaf/rascaline@5326b6e#subdirectory=python/rascaline-torch",
]
alchemical-model = [
"torch_alchemical @ git+https://github.com/abmazitov/torch_alchemical.git@51ff519",
]
pet = [
"pet @ git+https://github.com/lab-cosmo/pet@5d40710",
]
Expand Down
13 changes: 0 additions & 13 deletions src/metatrain/experimental/alchemical_model/__init__.py

This file was deleted.

33 changes: 0 additions & 33 deletions src/metatrain/experimental/alchemical_model/default-hypers.yaml

This file was deleted.

Loading