Remove alchemical model #425
Merged
+8
−1,766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostedoyster
force-pushed
the
remove-alchemical
branch
from
71f43db to
47b3425
Compare
|
Hold on, I thought we put it to deprecated models, not remove it completely from the repo @Luthaf please correct me if I’m wrong |
|
If nobody is using the code, is there a reason to keep it in |
|
IMO we don't gain much by putting it in deprecated, we would still have to maintain it. Deprecated is mainly to tell users "stop using this model, it might be gone soon" |
abmazitov
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed
Contributor (creator of pull-request) checklist
📚 Documentation preview 📚: https://metatrain--425.org.readthedocs.build/en/425/