Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed soa:Geo class representation #80

Merged
merged 4 commits into from
May 27, 2024

Conversation

linnaung
Copy link
Member

@linnaung linnaung commented Jan 5, 2024

The following items are addressed:

  • updated properties for soa:Geo class
  • fixed mapping script for soa:Geo class

@linnaung linnaung linked an issue Jan 5, 2024 that may be closed by this pull request
@davidlamprecht
Copy link
Collaborator

Why are the properties https://dbpedia.org/property/city and https://dbpedia.org/property/country deleted in the Geo object? I would keep this information as Strings for the sake of simplicity (although it can be retrieved via owl:sameAs https://sws.geonames.org/3149318/).

@linnaung
Copy link
Member Author

Why are the properties https://dbpedia.org/property/city and https://dbpedia.org/property/country deleted in the Geo object? I would keep this information as Strings for the sake of simplicity (although it can be retrieved via owl:sameAs https://sws.geonames.org/3149318/).

it's a good point. i'll retain city and country info.

 - updated properties  for soa:Geo class
 - fixed mapping script for soa:Geo class
@linnaung linnaung force-pushed the fix-Geo-class-representation branch from 791a90a to ba1b6b0 Compare May 24, 2024 07:18
@linnaung linnaung force-pushed the fix-Geo-class-representation branch from ba1b6b0 to e85d57f Compare May 24, 2024 07:19
@davidlamprecht
Copy link
Collaborator

I would not remove

geo_region = institution_geo['region'] if not geo_region is None: institutions_graph.add((geo_uri,region_predicate,Literal(geo_region,datatype=XSD.string)))

but leave it as String in the code like city and country info using the defined region predicate: region_predicate = URIRef("https://dbpedia.org/property/region")

Copy link
Collaborator

@davidlamprecht davidlamprecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@davidlamprecht davidlamprecht merged commit 087431b into main May 27, 2024
@davidlamprecht davidlamprecht deleted the fix-Geo-class-representation branch May 27, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix Geonames props
2 participants