GenericCLI: Support for multiple positional arguments #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit91
force-pushed
the
multiple-id-args
branch
from
5a7ff12 to
ef643cb
Compare
Gerrit91
changed the title
vknabel
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we can only generate commands like
describe <id>. However, some APIs have compound keys for IDs, e.g. for size reservations it's useful to havedescribe <project> <size>, which makes a unique identifier for this API.This was implemented as non-breaking. If you have multiple positional arguments to pass, you can now do so by using
MultiArgGenericCLI.Internally, the entire old implementation with the single positional argument interface is mapped to the new multi argument interface to reduce code redundancy and maintain test-ability of this package.