Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move size reservations to a dedicated table. #576

Merged
merged 11 commits into from
Sep 30, 2024
Merged

Conversation

Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Sep 20, 2024

Now that we would like to offer size reservations directly to customers, it appears that managing all the size reservations inside a slice of a size is quite complicated.

For just operator-usage this is fine, but if you want to select specific reservation entities, it's quite difficult for individual projects that do not have access to the entire reservation slice. It leads to CLI commands like machine-reservation describe <partition> <project> <size> in order to correctly identify a reservation (see GenericCLI PR here). But then it's still quite hard to select the proper reservation because you need to introduce implicit conventions for uniqueness. What it really lacks is an identifier.

In order to solve this, we should just treat the entity like any other and put it into a dedicated table. We can then also just have regular CRUD endpoints for the entity, which makes it easier to handle.

This is unfortunately a breaking change because the size reservations move away from the size entity. But for now only operators have been using this feature, so a breaking change should not have such a big impact on this resource.

Breaking Change

Size reservations were moved into a dedicated table and are not directly part of the size entity anymore. In this context, the API has also been slightly changed. If you used size reservations in your deployment, please adopt to the new deployment scheme. Existing reservations are migrated into the new table and do not get lost.

@Gerrit91 Gerrit91 marked this pull request as ready for review September 27, 2024 08:33
@Gerrit91 Gerrit91 requested a review from a team as a code owner September 27, 2024 08:33
@Gerrit91 Gerrit91 requested a review from majst01 September 27, 2024 08:33
@Gerrit91 Gerrit91 requested review from majst01, mwennrich, vknabel and a team September 30, 2024 11:28
@Gerrit91 Gerrit91 merged commit 6c79219 into master Sep 30, 2024
2 checks passed
@Gerrit91 Gerrit91 deleted the size-reservations-table branch September 30, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants