Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mdb_stat for db.len() #99

Closed
wants to merge 19 commits into from
Closed

Use mdb_stat for db.len() #99

wants to merge 19 commits into from

Conversation

Keats
Copy link

@Keats Keats commented Jan 28, 2021

Closes #56

@Kerollmops
Copy link
Member

Hey, thank you for the changes but could you change the base branch, please? You can do that by clicking the EDIT button for changing the title and move it to the v0.11 branch.

The changes that you are introducing are breaking and I must publish a new breaking version, the 0.11.0 one, I would like to make some more breaking changes in this version (#87, #91, and maybe #89) what do you think?

@Keats Keats changed the base branch from master to v0.11 January 28, 2021 13:12
@Kerollmops
Copy link
Member

Hum... it seems like you also need to rebase (or cherry-pick) your commit on the v0.11 branch too! Sorry about that.

@Keats
Copy link
Author

Keats commented Jan 28, 2021

Hum... it seems like you also need to rebase (or cherry-pick) your commit on the v0.11 branch too! Sorry about that.

yep doing it now

@Kerollmops
Copy link
Member

Note that I will maybe also bump the libmdbx version used by heed right now, from 0.7.1 to 0.9.2. What do you think about waiting for this PR to be merged and being able to bump the heed mdbx dependency?

@Keats
Copy link
Author

Keats commented Jan 28, 2021

#100 for the clean PR.
As for breaking changes it looks ok, but it would be good to see where https://github.com/Kerollmops/heed/pull/91/files#diff-ba6e7475acd6f0ab6e49c1ab56ea00c887d3f436dcd32acc0d927cf901ec8fb2 is coming from

@Keats Keats closed this Jan 28, 2021
@Keats
Copy link
Author

Keats commented Jan 28, 2021

Note that I will maybe also bump the libmdbx version used by heed right now, from 0.7.1 to 0.9.2. What do you think about waiting for this PR to be merged and being able to bump the heed mdbx dependency?

Works for me, I'm not in a hurry.

@Kerollmops
Copy link
Member

[...] but it would be good to see where https://github.com/Kerollmops/heed/pull/91/files#diff-ba6e7475acd6f0ab6e49c1ab56ea00c887d3f436dcd32acc0d927cf901ec8fb2 is coming from

This code comes from the zerocopy crate, and you are right I will not merge that one for the v0.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the poly/database length function
2 participants