-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support env_stat #97
Comments
Hey @Keats, I believe it is easy to add two new methods:
Do be able to use these However, I would prefer that we return two different structs for the two methods, I don't find the |
What would you change? The main thing I wanted the DB stat struct for is the number of entries to (so it's not slow like right now, solving #56 as you point out) and to calculate the space used (https://wiki.samba.org/index.php/Using_the_lmdb_database_backend#Calculating_space_used). I don't think I would need the env stat struct myself but it could definitely be added for the sake of completeness. |
First thing I don't quite like is the documentation and those other fields that are not that obvious.
Maybe you could first fix #56 by extracting the number of entries from the I will create a 0.10 branch to be able to update the currently published crate version as I am currently doing a lot of changes for a 0.11 version right now. But don't worry I will ask you to change the base branch directly on GitHub if you publish a PR on master. |
Closed by #100. |
Taken from the python bindings docs for LMDB: https://lmdb.readthedocs.io/en/release/#lmdb.Environment.stat
Would it be possible to expose that function?
The text was updated successfully, but these errors were encountered: